You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/07 11:34:03 UTC

[GitHub] [cloudstack] davidjumani commented on pull request #5725: simplify code using object shorthand in storage views

davidjumani commented on pull request #5725:
URL: https://github.com/apache/cloudstack/pull/5725#issuecomment-987842842


   While using object shorthand is a good idea, creating variables with empty / null / static values just to be returned a couple of lines down can actually reduce the readability. @Damans227 Can you look at other areas where doing so will make reading the code easier or simplify it ? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org