You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kanna Karanam (JIRA)" <ji...@apache.org> on 2012/06/13 19:41:42 UTC
[jira] [Created] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Kanna Karanam created HIVE-3126:
-----------------------------------
Summary: Generate & build the velocity based Hive tests on windows by fixing the path issues
Key: HIVE-3126
URL: https://issues.apache.org/jira/browse/HIVE-3126
Project: Hive
Issue Type: Bug
Components: Tests
Affects Versions: 0.9.0, 0.10.0, 0.9.1
Reporter: Kanna Karanam
Fix For: 0.10.0
1)Escape the backward slash in Canonical Path if unit test runs on windows.
2)Diff comparison –
a. Ignore the extra spacing on windows
b. Ignore the different line endings on windows & Unix
c. Convert the file paths to windows specific. (Handle spaces etc..)
3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.4.patch.txt
Thanks Carl. This feedback helped me to move the path conversion/escaping logic from .vm files to QTestGen task. It is a code generation logic so to even create a file object, we need to get the absolute path in a string format so we can’t skip the escaping logic. Here is the generated code line. (new File("D:\\OSS\\Hive\\ql\\src\\test\\queries\\clientpositive\\input37.q");
File, Path, & URI objects are helping us to work across Windows & Unix operating systems with no explicit conversions. But when it comes to Hadoop, JAVA can’t convert the URIs between “local file system” vs “hdfs”. URIs in Unix & HDFS are more or less same format and the paths in Unix don’t contain “:” character so we don’t notice this problem. In windows, because of the”:” Hadoop treats the windows drive letter as file scheme so we need to remove it to avoid this problem.
Thanks
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421569#comment-13421569 ]
Kanna Karanam commented on HIVE-3126:
-------------------------------------
@Carl, @Ashutosh - can you please review the updated diff? Thanks.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.6.patch.txt
Updated with the correct patch.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421853#comment-13421853 ]
Ashutosh Chauhan commented on HIVE-3126:
----------------------------------------
@Kanna: Thanks, Kanna. I will take a look.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416722#comment-13416722 ]
Ashutosh Chauhan commented on HIVE-3126:
----------------------------------------
Looks good to me. Running tests now.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Status: Patch Available (was: Open)
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3126:
---------------------------------
Status: Open (was: Patch Available)
@Kanna: I left a couple more comments on reviewboard (nothing big). Thanks.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Status: Patch Available (was: Open)
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401554#comment-13401554 ]
Kanna Karanam commented on HIVE-3126:
-------------------------------------
@Carl- I am still investigating some unit test failures on unix . I will upload the patch by end of day today. Thanks
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400282#comment-13400282 ]
Kanna Karanam commented on HIVE-3126:
-------------------------------------
Thanks Carl. I will look into it.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13393554#comment-13393554 ]
Edward Capriolo commented on HIVE-3126:
---------------------------------------
Will tests generated on windows run on linux and vice versa?
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418816#comment-13418816 ]
Kanna Karanam commented on HIVE-3126:
-------------------------------------
@Carl – I added some follow up comments. can you please look into them?
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413455#comment-13413455 ]
Ashutosh Chauhan commented on HIVE-3126:
----------------------------------------
Looks like I referenced wrong jura-id in my svn commit message. I committed HIVE-3204 not this one. I have corrected svn commit message in repo too.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.7.patch.txt
Addressed Ashutosh’s review comments and updated the diff file. Thanks
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402890#comment-13402890 ]
Carl Steinbach commented on HIVE-3126:
--------------------------------------
@Kanna: I added some more comments on reviewboard. Thanks.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3126:
---------------------------------
Status: Open (was: Patch Available)
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13393657#comment-13393657 ]
Kanna Karanam commented on HIVE-3126:
-------------------------------------
Hi Edward – It is a good point. Hive development on Windows is not ready yet, still around 20% of unit tests are failing. So I am working on addressing them in subsequent JIRAs (Sub tasks of this JIRA & not created them yet). This Patch will enable other developers to build and fix any of the existing UT failures on Windows. Here is my plan to get the Windows development environment ready.
1) This JIRA addresses to generate and build the velocity based unit tests on Windows.
2) I will be creating bunch of JIRAs to address the UT failures on Windows (It completes the work to run all UTs generated on Linux to work on Windows)
3) Enable the Hive development on Windows . it will address UTs developed on Windows to work on Linux too.
Please let me know if I missed anything.
Thanks
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.1.patch.txt
Attched the patch
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3126:
-----------------------------------
Status: Patch Available (was: Open)
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.9.patch.txt
Thanks Carl. Can you please review the update diff.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan reassigned HIVE-3126:
--------------------------------------
Assignee: Kanna Karanam
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.8.patch.txt
Thanks Carl. Updated the diff with some of your suggestions.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421895#comment-13421895 ]
Carl Steinbach commented on HIVE-3126:
--------------------------------------
Looks good to me. Kanna, thanks for making all of these changes.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400188#comment-13400188 ]
Kanna Karanam commented on HIVE-3126:
-------------------------------------
Code review request is at https://reviews.apache.org/r/5540/
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.3.patch.txt
Updated the patch.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402370#comment-13402370 ]
Kanna Karanam commented on HIVE-3126:
-------------------------------------
Updated the patch after addressing most of the review comments
1) Replaced most of the Windows specific checks in build.xml files with generic OS check approach.
2) Removed some of the if(Windows) checks in the production code.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Status: Patch Available (was: Open)
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3126:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Kanna for your perseverance on this one!
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3126:
---------------------------------
Status: Open (was: Patch Available)
@Kanna: I responded to your comments. Thanks.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407492#comment-13407492 ]
Kanna Karanam commented on HIVE-3126:
-------------------------------------
@Carl. Please let me know if you have any additional comments.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421913#comment-13421913 ]
Ashutosh Chauhan commented on HIVE-3126:
----------------------------------------
+1 Will commit if tests pass.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399738#comment-13399738 ]
Carl Steinbach commented on HIVE-3126:
--------------------------------------
@Kanna: Please create a review request. Thanks.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413448#comment-13413448 ]
Hudson commented on HIVE-3126:
------------------------------
Integrated in Hive-trunk-h0.21 #1539 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1539/])
HIVE-3126 :Windows: Fix the unit tests which contains cmd commands (Unix shell commands) (Kanna Karanam via Ashutosh Chauhan) (Revision 1360825)
Result = SUCCESS
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1360825
Files :
* /hive/trunk/ql/src/test/queries/clientnegative/exim_00_unsupported_schema.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_01_nonpart_over_loaded.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_02_all_part_over_overlap.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_03_nonpart_noncompat_colschema.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_04_nonpart_noncompat_colnumber.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_05_nonpart_noncompat_coltype.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_06_nonpart_noncompat_storage.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_07_nonpart_noncompat_ifof.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_08_nonpart_noncompat_serde.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_09_nonpart_noncompat_serdeparam.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_10_nonpart_noncompat_bucketing.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_11_nonpart_noncompat_sorting.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_13_nonnative_import.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_14_nonpart_part.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_15_part_nonpart.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_16_part_noncompat_schema.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_17_part_spec_underspec.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_18_part_spec_missing.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_19_external_over_existing.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_20_managed_location_over_existing.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_21_part_managed_external.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_22_export_authfail.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_23_import_exist_authfail.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_24_import_part_authfail.q
* /hive/trunk/ql/src/test/queries/clientnegative/exim_25_import_nonexist_authfail.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_00_nonpart_empty.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_01_nonpart.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_02_00_part_empty.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_02_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_03_nonpart_over_compat.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_04_all_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_04_evolved_parts.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_05_some_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_06_one_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_07_all_part_over_nonoverlap.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_08_nonpart_rename.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_09_part_spec_nonoverlap.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_10_external_managed.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_11_managed_external.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_12_external_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_13_managed_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_14_managed_location_over_existing.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_15_external_part.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_16_part_external.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_17_part_managed.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_18_part_external.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_19_00_part_external_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_19_part_external_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_20_part_managed_location.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_21_export_authsuccess.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_22_import_exist_authsuccess.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_23_import_part_authsuccess.q
* /hive/trunk/ql/src/test/queries/clientpositive/exim_24_import_nonexist_authsuccess.q
* /hive/trunk/ql/src/test/queries/clientpositive/insertexternal1.q
* /hive/trunk/ql/src/test/queries/clientpositive/multi_insert.q
* /hive/trunk/ql/src/test/queries/clientpositive/multi_insert_move_tasks_share_dependencies.q
* /hive/trunk/ql/src/test/results/clientnegative/exim_00_unsupported_schema.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_06_nonpart_noncompat_storage.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_07_nonpart_noncompat_ifof.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_08_nonpart_noncompat_serde.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_09_nonpart_noncompat_serdeparam.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_10_nonpart_noncompat_bucketing.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_11_nonpart_noncompat_sorting.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_13_nonnative_import.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_14_nonpart_part.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_16_part_noncompat_schema.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_17_part_spec_underspec.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_18_part_spec_missing.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_19_external_over_existing.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_20_managed_location_over_existing.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_21_part_managed_external.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_22_export_authfail.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_23_import_exist_authfail.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_24_import_part_authfail.q.out
* /hive/trunk/ql/src/test/results/clientnegative/exim_25_import_nonexist_authfail.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_00_nonpart_empty.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_01_nonpart.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_02_00_part_empty.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_02_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_03_nonpart_over_compat.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_04_all_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_04_evolved_parts.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_05_some_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_06_one_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_07_all_part_over_nonoverlap.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_08_nonpart_rename.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_09_part_spec_nonoverlap.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_10_external_managed.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_11_managed_external.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_12_external_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_13_managed_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_14_managed_location_over_existing.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_15_external_part.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_16_part_external.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_17_part_managed.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_18_part_external.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_19_00_part_external_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_19_part_external_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_20_part_managed_location.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_21_export_authsuccess.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_22_import_exist_authsuccess.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_23_import_part_authsuccess.q.out
* /hive/trunk/ql/src/test/results/clientpositive/exim_24_import_nonexist_authsuccess.q.out
* /hive/trunk/ql/src/test/results/clientpositive/insertexternal1.q.out
* /hive/trunk/ql/src/test/results/clientpositive/multi_insert.q.out
* /hive/trunk/ql/src/test/results/clientpositive/multi_insert_move_tasks_share_dependencies.q.out
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418064#comment-13418064 ]
Ashutosh Chauhan commented on HIVE-3126:
----------------------------------------
Changes look good to me. Carl, do you have any more comments for it?
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.2.patch.txt
Removed the workwround for long class path (It will be addressed in HIVE-3172) from existing patch.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.10.patch.txt
Updated the patch with latest source & fixed the windows path related issue to make more unit tests run on windows.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421947#comment-13421947 ]
Kanna Karanam commented on HIVE-3126:
-------------------------------------
Thanks Ashutosh, Carl. This JIRA helps developers to build, develop , & debug hive on windows. I am not done yet until I fix all other unit test failures but it helps the community to play on windows.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3126:
---------------------------------
Status: Open (was: Patch Available)
@Kanna: please see my comments on reviewboard. Thanks.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kanna Karanam updated HIVE-3126:
--------------------------------
Attachment: HIVE-3126.5.patch.txt
Updated the patch with latest OSS source.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413450#comment-13413450 ]
Ashutosh Chauhan commented on HIVE-3126:
----------------------------------------
[~kannakar@microsoft.com] : I left some comments on RB.
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422323#comment-13422323 ]
Hudson commented on HIVE-3126:
------------------------------
Integrated in Hive-trunk-h0.21 #1567 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1567/])
HIVE-3126 : Generate & build the velocity based Hive tests on windows by fixing the path issues (Kanna Karanam via Ashutosh Chauhan) (Revision 1365467)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1365467
Files :
* /hive/trunk/ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java
* /hive/trunk/build-common.xml
* /hive/trunk/build.xml
* /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
* /hive/trunk/conf/hive-default.xml.template
* /hive/trunk/contrib/src/test/org/apache/hadoop/hive/contrib/mr/TestGenericMR.java
* /hive/trunk/data/conf/hive-site.xml
* /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm
* /hive/trunk/hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm
* /hive/trunk/odbc/build.xml
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Context.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java
* /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
* /hive/trunk/ql/src/test/templates/TestCliDriver.vm
* /hive/trunk/ql/src/test/templates/TestNegativeCliDriver.vm
* /hive/trunk/ql/src/test/templates/TestParse.vm
* /hive/trunk/ql/src/test/templates/TestParseNegative.vm
* /hive/trunk/shims/src/common/java/org/apache/hadoop/fs/ProxyFileSystem.java
* /hive/trunk/shims/src/common/java/org/apache/hadoop/fs/ProxyLocalFileSystem.java
* /hive/trunk/testutils/hadoop.cmd
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.10.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt, HIVE-3126.4.patch.txt, HIVE-3126.5.patch.txt, HIVE-3126.6.patch.txt, HIVE-3126.7.patch.txt, HIVE-3126.8.patch.txt, HIVE-3126.9.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3126) Generate & build the velocity based
Hive tests on windows by fixing the path issues
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-3126:
-----------------------------------
Status: Patch Available (was: Open)
> Generate & build the velocity based Hive tests on windows by fixing the path issues
> -----------------------------------------------------------------------------------
>
> Key: HIVE-3126
> URL: https://issues.apache.org/jira/browse/HIVE-3126
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.9.0, 0.10.0, 0.9.1
> Reporter: Kanna Karanam
> Assignee: Kanna Karanam
> Labels: Windows, test
> Fix For: 0.10.0
>
> Attachments: HIVE-3126.1.patch.txt, HIVE-3126.2.patch.txt, HIVE-3126.3.patch.txt
>
>
> 1)Escape the backward slash in Canonical Path if unit test runs on windows.
> 2)Diff comparison –
> a. Ignore the extra spacing on windows
> b. Ignore the different line endings on windows & Unix
> c. Convert the file paths to windows specific. (Handle spaces etc..)
> 3)Set the right file scheme & class path separators while invoking the junit task from
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira