[GitHub] [spark] MaxGekk commented on a change in pull request #28016: [SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in write/read for ORC datasource

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #28016: [SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in write/read for ORC datasource
URL: https://github.com/apache/spark/pull/28016#discussion_r398331763
 
 

 ##########
 File path: sql/core/v1.2/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnVector.java
 ##########
 @@ -42,6 +43,7 @@
   private DecimalColumnVector decimalData;
   private TimestampColumnVector timestampData;
 
 Review comment:
   Yes, it does, but:
   1. `DateColumnVector` doesn't have a method similar to `asScratchTimestamp` in `TimestampColumnVector`
   2. We don't need to build `java.sql.Date` from serialized days to perform rebasing. It is unnecessary overhead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org