You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/17 12:29:45 UTC
[GitHub] [spark] techaddict opened a new pull request, #39108: [SPARK-41428] Protobuf serializer for SpeculationStageSummaryWrapper
techaddict opened a new pull request, #39108:
URL: https://github.com/apache/spark/pull/39108
### What changes were proposed in this pull request?
Add Protobuf serializer for SpeculationStageSummaryWrapper
### Why are the changes needed?
Support fast and compact serialization/deserialization for SpeculationStageSummaryWrapper over RocksDB.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
New UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #39108:
URL: https://github.com/apache/spark/pull/39108#issuecomment-1360861061
@techaddict Do you mind if I hold on to the review for one day and wait for the refactor in https://github.com/apache/spark/pull/39148?
cc @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #39108:
URL: https://github.com/apache/spark/pull/39108#discussion_r1054918539
##########
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto:
##########
@@ -244,3 +244,17 @@ message RDDStorageInfoWrapper {
message ResourceProfileWrapper {
ResourceProfileInfo rpInfo = 1;
}
+
+message SpeculationStageSummary {
+ int32 num_tasks = 1;
+ int32 num_active_tasks = 2;
+ int32 num_completed_tasks = 3;
+ int32 num_failed_tasks = 4;
+ int32 num_killed_tasks = 5;
+}
+
+message SpeculationStageSummaryWrapper {
+ int32 stage_id = 1;
Review Comment:
As per @mridulm , let's set all the stage/job/task id as int64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] techaddict commented on pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
Posted by GitBox <gi...@apache.org>.
techaddict commented on PR #39108:
URL: https://github.com/apache/spark/pull/39108#issuecomment-1360871014
@gengliangwang sounds good 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] techaddict commented on pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
Posted by GitBox <gi...@apache.org>.
techaddict commented on PR #39108:
URL: https://github.com/apache/spark/pull/39108#issuecomment-1360858286
@gengliangwang this PR is ready to be reviewed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
URL: https://github.com/apache/spark/pull/39108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] techaddict commented on pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
Posted by GitBox <gi...@apache.org>.
techaddict commented on PR #39108:
URL: https://github.com/apache/spark/pull/39108#issuecomment-1362204199
@gengliangwang addressed comments 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #39108:
URL: https://github.com/apache/spark/pull/39108#issuecomment-1362440875
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #39108:
URL: https://github.com/apache/spark/pull/39108#issuecomment-1361809347
@techaddict FYI https://github.com/apache/spark/pull/39148 is merged. Can you resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] techaddict commented on pull request #39108: [SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper
Posted by GitBox <gi...@apache.org>.
techaddict commented on PR #39108:
URL: https://github.com/apache/spark/pull/39108#issuecomment-1362168155
@techaddict updated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org