You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/15 18:59:01 UTC
[GitHub] [ozone] smengcl commented on a diff in pull request #3755: HDDS-7224. Create a new RocksDBCheckpoint Diff utility.
smengcl commented on code in PR #3755:
URL: https://github.com/apache/ozone/pull/3755#discussion_r972329299
##########
pom.xml:
##########
@@ -1843,36 +1843,6 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
</goals>
<configuration>
<rules>
- <RestrictImports>
- <includeTestCode>false</includeTestCode>
- <reason>Use managed RocksObjects under org.apache.hadoop.hdds.utils.db.managed instead.</reason>
- <!-- By default, ban all the classes in org.rocksdb -->
- <bannedImport>org.rocksdb.**</bannedImport>
- <allowedImports>
- <!-- Allow non-RocksObject classes. -->
- <allowedImport>org.rocksdb.BlockBasedTableConfig</allowedImport>
- <allowedImport>org.rocksdb.ColumnFamilyDescriptor</allowedImport>
- <allowedImport>org.rocksdb.CompactionStyle</allowedImport>
- <allowedImport>org.rocksdb.HistogramData</allowedImport>
- <allowedImport>org.rocksdb.HistogramType</allowedImport>
- <allowedImport>org.rocksdb.Holder</allowedImport>
- <allowedImport>org.rocksdb.InfoLogLevel</allowedImport>
- <allowedImport>org.rocksdb.OptionsUtil</allowedImport>
- <allowedImport>org.rocksdb.RocksDBException</allowedImport>
- <allowedImport>org.rocksdb.StatsLevel</allowedImport>
- <allowedImport>org.rocksdb.TransactionLogIterator.BatchResult</allowedImport>
- <allowedImport>org.rocksdb.TickerType</allowedImport>
-
- <!-- Allow RocksObjects whose native pointer is managed by RocksDB. -->
- <allowedImport>org.rocksdb.ColumnFamilyHandle</allowedImport>
- <allowedImport>org.rocksdb.Env</allowedImport>
- <allowedImport>org.rocksdb.Statistics</allowedImport>
-
- <!-- Allow RocksDB constants and static methods to be used. -->
- <allowedImport>org.rocksdb.RocksDB.*</allowedImport>
- </allowedImports>
- <exclusion>org.apache.hadoop.hdds.utils.db.managed.*</exclusion>
- </RestrictImports>
Review Comment:
We have to add the extra needed imports rather than removing this bulk. Simply copy and paste the class/artifact names emitted from maven compile error message here to new `allowedImport` entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org