[GitHub] srowen commented on a change in pull request #23878: [SPARK-26978][CORE][SQL] Avoid magic time constants

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23878: [SPARK-26978][CORE][SQL] Avoid magic time constants
URL: https://github.com/apache/spark/pull/23878#discussion_r259938127
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
 ##########
 @@ -927,7 +929,8 @@ case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String
       val tz = JavaCode.global(ctx.addReferenceObj("timeZone", timeZone), timeZone.getClass)
       (c, evPrim, evNull) =>
         code"""$evPrim =
-          org.apache.spark.sql.catalyst.util.DateTimeUtils.millisToDays($c / 1000L, $tz);"""
+          org.apache.spark.sql.catalyst.util.DateTimeUtils.millisToDays(
 
 Review comment:
   I agree with you @kiszk; this probably only adds a few ops though to invoke a static method vs a division. The issue here is the size of the generated bytecode, so the implementation of `toMillis` doesn't matter nor whether it's JITted at runtime.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org