You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2010/08/28 14:57:53 UTC
[jira] Created: (WICKET-3024) HttpsRequestChecker inadvertently
instantiates page when checking for annotation
HttpsRequestChecker inadvertently instantiates page when checking for annotation
--------------------------------------------------------------------------------
Key: WICKET-3024
URL: https://issues.apache.org/jira/browse/WICKET-3024
Project: Wicket
Issue Type: Bug
Reporter: Peter Ertl
Attachments: https.patch
when checking for https the page class unnecessarily instantiated which will cause premature execution of the page constructor. In my case I threw a redirect which was not handled properly. So this issue not only a matter on efficiency but also erroneous.
patch follows in a sec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3024) HttpsRequestChecker inadvertently
instantiates page when checking for annotation
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3024.
-----------------------------------
Resolution: Fixed
> HttpsRequestChecker inadvertently instantiates page when checking for annotation
> --------------------------------------------------------------------------------
>
> Key: WICKET-3024
> URL: https://issues.apache.org/jira/browse/WICKET-3024
> Project: Wicket
> Issue Type: Bug
> Reporter: Peter Ertl
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
> Attachments: https-test-case.patch, https.patch
>
>
> when checking for https the page class unnecessarily instantiated which will cause premature execution of the page constructor. In my case I threw a redirect which was not handled properly. So this issue not only a matter on efficiency but also erroneous.
> patch follows in a sec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3024) HttpsRequestChecker inadvertently
instantiates page when checking for annotation
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3024.
-----------------------------------
Assignee: Igor Vaynberg
Fix Version/s: 1.5-M2
Resolution: Fixed
> HttpsRequestChecker inadvertently instantiates page when checking for annotation
> --------------------------------------------------------------------------------
>
> Key: WICKET-3024
> URL: https://issues.apache.org/jira/browse/WICKET-3024
> Project: Wicket
> Issue Type: Bug
> Reporter: Peter Ertl
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
> Attachments: https.patch
>
>
> when checking for https the page class unnecessarily instantiated which will cause premature execution of the page constructor. In my case I threw a redirect which was not handled properly. So this issue not only a matter on efficiency but also erroneous.
> patch follows in a sec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3024) HttpsRequestChecker inadvertently
instantiates page when checking for annotation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904667#action_12904667 ]
Hudson commented on WICKET-3024:
--------------------------------
Integrated in Apache Wicket 1.5.x #281 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/281/])
fixed test
Issue: WICKET-3024
> HttpsRequestChecker inadvertently instantiates page when checking for annotation
> --------------------------------------------------------------------------------
>
> Key: WICKET-3024
> URL: https://issues.apache.org/jira/browse/WICKET-3024
> Project: Wicket
> Issue Type: Bug
> Reporter: Peter Ertl
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
> Attachments: https-test-case.patch, https.patch
>
>
> when checking for https the page class unnecessarily instantiated which will cause premature execution of the page constructor. In my case I threw a redirect which was not handled properly. So this issue not only a matter on efficiency but also erroneous.
> patch follows in a sec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3024) HttpsRequestChecker inadvertently
instantiates page when checking for annotation
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-3024:
-------------------------------
Attachment: https.patch
> HttpsRequestChecker inadvertently instantiates page when checking for annotation
> --------------------------------------------------------------------------------
>
> Key: WICKET-3024
> URL: https://issues.apache.org/jira/browse/WICKET-3024
> Project: Wicket
> Issue Type: Bug
> Reporter: Peter Ertl
> Attachments: https.patch
>
>
> when checking for https the page class unnecessarily instantiated which will cause premature execution of the page constructor. In my case I threw a redirect which was not handled properly. So this issue not only a matter on efficiency but also erroneous.
> patch follows in a sec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3024) HttpsRequestChecker inadvertently
instantiates page when checking for annotation
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl updated WICKET-3024:
-------------------------------
Attachment: https-test-case.patch
> HttpsRequestChecker inadvertently instantiates page when checking for annotation
> --------------------------------------------------------------------------------
>
> Key: WICKET-3024
> URL: https://issues.apache.org/jira/browse/WICKET-3024
> Project: Wicket
> Issue Type: Bug
> Reporter: Peter Ertl
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
> Attachments: https-test-case.patch, https.patch
>
>
> when checking for https the page class unnecessarily instantiated which will cause premature execution of the page constructor. In my case I threw a redirect which was not handled properly. So this issue not only a matter on efficiency but also erroneous.
> patch follows in a sec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-3024) HttpsRequestChecker inadvertently
instantiates page when checking for annotation
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl reopened WICKET-3024:
--------------------------------
the test case was broken as it still relied on HttpsRequestChecker calling getPage() which is wrong.
Patch for fixing test case is attached.
> HttpsRequestChecker inadvertently instantiates page when checking for annotation
> --------------------------------------------------------------------------------
>
> Key: WICKET-3024
> URL: https://issues.apache.org/jira/browse/WICKET-3024
> Project: Wicket
> Issue Type: Bug
> Reporter: Peter Ertl
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
> Attachments: https.patch
>
>
> when checking for https the page class unnecessarily instantiated which will cause premature execution of the page constructor. In my case I threw a redirect which was not handled properly. So this issue not only a matter on efficiency but also erroneous.
> patch follows in a sec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3024) HttpsRequestChecker inadvertently
instantiates page when checking for annotation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904466#action_12904466 ]
Hudson commented on WICKET-3024:
--------------------------------
Integrated in Apache Wicket 1.5.x #279 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/279/])
> HttpsRequestChecker inadvertently instantiates page when checking for annotation
> --------------------------------------------------------------------------------
>
> Key: WICKET-3024
> URL: https://issues.apache.org/jira/browse/WICKET-3024
> Project: Wicket
> Issue Type: Bug
> Reporter: Peter Ertl
> Assignee: Igor Vaynberg
> Fix For: 1.5-M2
>
> Attachments: https.patch
>
>
> when checking for https the page class unnecessarily instantiated which will cause premature execution of the page constructor. In my case I threw a redirect which was not handled properly. So this issue not only a matter on efficiency but also erroneous.
> patch follows in a sec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.