You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/01/23 16:43:19 UTC
[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9100
to review the following change.
Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
......................................................................
IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Jenkins jobs occasionally hang on test_query_cancellation_during_fetch.
There was a workaround proposal submitted under this Jira ID, however,
apparently jobs still hang on this test randomly. Reverting the
workaround and skipping the test until further fix proposal provided.
This reverts commit 7810d1f9a2c7d59b4b916d4d1793672cd8c33143.
Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Reviewed-on: http://gerrit.cloudera.org:8080/8972
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/shell/test_shell_commandline.py
M tests/shell/util.py
2 files changed, 11 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/9100/1
--
To view, visit http://gerrit.cloudera.org:8080/9100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Gerrit-Change-Number: 9100
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 )
Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
......................................................................
Patch Set 1: Code-Review+2
I'm testing GVO on the 2.x branch. Please ignore this review.
(This is a clean cherrypick, but I want to make sure GVO works appropriately on cherrypicks that may not be clean by trying to run this one through GVO.)
+2 review since it's a clean pick. I'm about to kick off GVO.
--
To view, visit http://gerrit.cloudera.org:8080/9100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Gerrit-Change-Number: 9100
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 16:44:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Hello Gabor Kaszab, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9100
to look at the new patch set (#2).
Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
......................................................................
IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Jenkins jobs occasionally hang on test_query_cancellation_during_fetch.
There was a workaround proposal submitted under this Jira ID, however,
apparently jobs still hang on this test randomly. Reverting the
workaround and skipping the test until further fix proposal provided.
This reverts commit 7810d1f9a2c7d59b4b916d4d1793672cd8c33143.
Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Reviewed-on: http://gerrit.cloudera.org:8080/8972
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/shell/test_shell_commandline.py
M tests/shell/util.py
2 files changed, 11 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/9100/2
--
To view, visit http://gerrit.cloudera.org:8080/9100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Gerrit-Change-Number: 9100
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 )
Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1783/
--
To view, visit http://gerrit.cloudera.org:8080/9100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Gerrit-Change-Number: 9100
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 20:24:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 )
Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
......................................................................
Patch Set 1:
GVO failed, but we know this test is flaky. (There's a fix for that.)
"[gw12] FAILED query_test/test_observability.py::TestObservability::test_query_profile_thrift_timestamps"
--
To view, visit http://gerrit.cloudera.org:8080/9100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Gerrit-Change-Number: 9100
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 20:30:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 )
Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1783/
--
To view, visit http://gerrit.cloudera.org:8080/9100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Gerrit-Change-Number: 9100
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jan 2018 16:45:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9100 )
Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
......................................................................
IMPALA-6318: Revert "Adjustment for hanging query cancellation test"
Jenkins jobs occasionally hang on test_query_cancellation_during_fetch.
There was a workaround proposal submitted under this Jira ID, however,
apparently jobs still hang on this test randomly. Reverting the
workaround and skipping the test until further fix proposal provided.
This reverts commit 7810d1f9a2c7d59b4b916d4d1793672cd8c33143.
Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Reviewed-on: http://gerrit.cloudera.org:8080/8972
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/shell/test_shell_commandline.py
M tests/shell/util.py
2 files changed, 11 insertions(+), 13 deletions(-)
Approvals:
Philip Zeyliger: Looks good to me, approved
Objections:
Impala Public Jenkins: Fails
--
To view, visit http://gerrit.cloudera.org:8080/9100
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I51acee49b5a17c4852410b7568fd1d092b114a6d
Gerrit-Change-Number: 9100
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>