[lucene-solr] branch reference_impl_dev updated: @444 Don't track lifecycle on SyncStrategy for now.

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl_dev by this push:
     new d3be447  @444 Don't track lifecycle on SyncStrategy for now.
d3be447 is described below

commit d3be4476a389fc5a074e5a1ef3eba2ea31827fd6
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Tue Jul 28 20:40:27 2020 -0500

    @444 Don't track lifecycle on SyncStrategy for now.
---
 solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java b/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
index 1ad19a1..14fbd11 100644
--- a/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
+++ b/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
@@ -67,7 +67,9 @@ public class SyncStrategy implements Closeable {
   }
   
   public SyncStrategy(CoreContainer cc) {
-    ObjectReleaseTracker.track(this);
+    // don't track currently - can be left open by a late election,
+    // but currently holds no resources to release anyway
+    // assert ObjectReleaseTracker.track(this);
     UpdateShardHandler updateShardHandler = cc.getUpdateShardHandler();
     shardHandler = ((HttpShardHandlerFactory)cc.getShardHandlerFactory()).getShardHandler(cc.getUpdateShardHandler().getUpdateOnlyHttpClient());
   }
@@ -280,7 +282,9 @@ public class SyncStrategy implements Closeable {
   
   public void close() {
     this.isClosed = true;
-    ObjectReleaseTracker.release(this);
+    // don't track currently - can be left open by a late election,
+    // but currently holds no resources to release anyway
+    // assert ObjectReleaseTracker.release(this);
   }
   
   public static ModifiableSolrParams params(String... params) {