You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 20:49:49 UTC
[GitHub] [arrow] jonkeane opened a new pull request #10254: ARROW-12660: [R] release cleanup [WIP]
jonkeane opened a new pull request #10254:
URL: https://github.com/apache/arrow/pull/10254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10254: ARROW-12660: [R] release cleanup
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#discussion_r627465379
##########
File path: r/NEWS.md
##########
@@ -17,17 +17,21 @@
under the License.
-->
-# arrow 4.0.0.9000
+# arrow 4.0.0.9000 (under development)
-# arrow 3.0.0.9000
+# arrow 4.0.0.1
+ * The mimalloc memory allocator is the default memory allocator when using a static source build of the package on Linux. This is because it has better behavior under valgrind than jemalloc does. A full-featured build (installed with `LIBARROW_MINIMAL=false`) includes both jemalloc and mimalloc, and it has still has jemalloc as default, though this is configurable at runtime with the `ARROW_DEFAULT_MEMORY_POOL` environment variable.
+ * Environment variables `LIBARROW_MINIMAL`, `LIBARROW_DOWNLOAD`, and `NOT_CRAN` are now case-insensitive in the Linux build script.
+ * A build configuration issue in the macOS binary package has been resolved.
+# arrow 4.0.0
Review comment:
Add line breaks
```suggestion
# arrow 4.0.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10254: ARROW-12660: [R] release cleanup [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#issuecomment-832999427
Revision: 2e79682e8b95fbfcccfde645fa233defddd27ed3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-399](https://github.com/ursacomputing/crossbow/branches/all?query=actions-399)
|Task|Status|
|----|------|
|conda-linux-gcc-py36-cpu-r36|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-conda-linux-gcc-py36-cpu-r36)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-osx-clang-py36-r36|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-conda-osx-clang-py36-r36)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-conda-osx-clang-py37-r40)|
|conda-win-vs2017-py36-r36|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-conda-win-vs2017-py36-r36)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-conda-win-vs2017-py37-r40)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-399-github-homebrew-r-autobrew)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-399-github-test-r-devdocs)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-399-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-399-github-test-r-linux-as-cran)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-minimal-build)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-r-version-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-399-github-test-r-version-compatibility)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-399-github-test-r-versions)|
|test-r-without-arrow|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-r-without-arrow)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-399-azure-test-ubuntu-18.04-r-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10254: ARROW-12660: [R] release cleanup
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#discussion_r627474623
##########
File path: r/tools/nixlibs.R
##########
@@ -212,21 +212,30 @@ find_available_binary <- function(os) {
download_source <- function() {
Review comment:
It would probably be better to pass the global variable `VERSION` as the argument `version` in the call to `download_source()` and then refer to it here in the function as `version`. But maybe this PR isn't the place for that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10254: ARROW-12660: [R] Post-4.0 adjustments for CRAN
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#issuecomment-833732222
Yeah, I'm nearly certain it is unrelated + transient, I saw it pass earlier on this same PR with no operative changes between then and now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #10254: ARROW-12660: [R] release cleanup
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#discussion_r627501708
##########
File path: r/NEWS.md
##########
@@ -17,17 +17,23 @@
under the License.
-->
-# arrow 4.0.0.9000
+# arrow 4.0.0.9000 (under development)
Review comment:
This line gets autogenerated/updated by a script so we shouldn't stick other information here
```suggestion
# arrow 4.0.0.9000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10254: ARROW-12660: [R] release cleanup
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#discussion_r627500193
##########
File path: r/tools/nixlibs.R
##########
@@ -212,21 +212,30 @@ find_available_binary <- function(os) {
download_source <- function() {
Review comment:
Yeah, I agree, though think a follow on is probably better for that (maybe along with a way to select a binary version for developers?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #10254: ARROW-12660: [R] Post-4.0 adjustments for CRAN
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #10254:
URL: https://github.com/apache/arrow/pull/10254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10254: ARROW-12660: [R] release cleanup [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#issuecomment-832998179
https://issues.apache.org/jira/browse/ARROW-12660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10254: ARROW-12660: [R] release cleanup [WIP]
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#issuecomment-832998913
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #10254: ARROW-12660: [R] release cleanup
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#issuecomment-833594907
Can you please also give this a better issue/PR title; we shouldn't say "release" either (that has special Apache meaning). Maybe `[R] Post-4.0 adjustments for CRAN` or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10254: ARROW-12660: [R] release cleanup
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10254:
URL: https://github.com/apache/arrow/pull/10254#discussion_r627504466
##########
File path: r/NEWS.md
##########
@@ -17,17 +17,23 @@
under the License.
-->
-# arrow 4.0.0.9000
+# arrow 4.0.0.9000 (under development)
Review comment:
Womp womp, that's unfortunate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org