[GitHub] [skywalking] wu-sheng commented on a change in pull request #7606: Fix dynamic configuration watch implementation current value not null when the config is deleted.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #7606:
URL: https://github.com/apache/skywalking/pull/7606#discussion_r698296938



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/logging/LoggingConfigWatcher.java
##########
@@ -63,14 +64,6 @@ public void notify(final ConfigChangeEvent value) {
             log.error("failed to apply configuration to log4j", t);
             return;
         }
-        StringBuilder builder = new StringBuilder();
-        ctx.getConfiguration().getLoggers().forEach((loggerName, config) -> {
-            builder.append(Strings.isNullOrEmpty(loggerName) ? "Root" : loggerName)
-                   .append(":")
-                   .append(config.getLevel())
-                   .append(",");
-        });
-        this.content = builder.toString();

Review comment:
       @hanahmily This was a bug of old codes, which cause endless loop of update notification.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org