You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "CoolGuy (Jira)" <ji...@apache.org> on 2021/08/14 01:51:00 UTC
[jira] [Updated] (KAFKA-13186) Proposal for commented code

     [ https://issues.apache.org/jira/browse/KAFKA-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

CoolGuy updated KAFKA-13186:
----------------------------
    Description: 
Hello! I saw in your [coding guidelines|https://kafka.apache.org/coding-guide.html] that ??Don't check in commented out code. ??
However, I still witness commented code in some files like:

* connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ConnectorConfigTest.java
* streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedKeyValueBufferTest.java
* clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java

 
Would you like to remove these commented code lines?
If so, I may help and open a pull request.

 

 

  was:
Hello! I saw in your [coding guidelines|https://kafka.apache.org/coding-guide.html] that ??Don't check in commented out code. ??

However, I still witness commented code in some files like:

/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ConnectorConfigTest.java

/streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedKeyValueBufferTest.java

/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java

 

Would you like to remove these commented codes?

If so, I may help and open a pull request.

 

 


> Proposal for commented code
> ---------------------------
>
>                 Key: KAFKA-13186
>                 URL: https://issues.apache.org/jira/browse/KAFKA-13186
>             Project: Kafka
>          Issue Type: Wish
>            Reporter: CoolGuy
>            Priority: Trivial
>
> Hello! I saw in your [coding guidelines|https://kafka.apache.org/coding-guide.html] that ??Don't check in commented out code. ??
> However, I still witness commented code in some files like:
> * connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ConnectorConfigTest.java
> * streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedKeyValueBufferTest.java
> * clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
>  
> Would you like to remove these commented code lines?
> If so, I may help and open a pull request.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)