[GitHub] [tvm] mbrookhart commented on a diff in pull request #12124: [Relay][Op] Trilu operator implementation

[GitBox <gi...@apache.org>]

mbrookhart commented on code in PR #12124:
URL: https://github.com/apache/tvm/pull/12124#discussion_r930088467


##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -5241,23 +5241,7 @@ def verify_eyelike(indata, dynamic=False):
     "test_training_dropout_mask",
     "test_training_dropout_zero_ratio",
     "test_training_dropout_zero_ratio_mask",
-    "test_tril",
-    "test_tril_pos",
-    "test_tril_square",
-    "test_tril_square_neg",
-    "test_tril_neg",
-    "test_tril_one_row_neg",
-    "test_tril_out_neg",
-    "test_tril_out_pos",
     "test_tril_zero",

Review Comment:
   I haven't looked at this op at all. How tricky would it be to support the zero case? Otherwise LGTM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org