You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 03:50:44 UTC
[GitHub] [airflow] uranusjr opened a new pull request, #23106: Show warning if '/' is used in a DAG run ID
uranusjr opened a new pull request, #23106:
URL: https://github.com/apache/airflow/pull/23106
Close #20063?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #23106: Show warning if '/' is used in a DAG run ID
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #23106:
URL: https://github.com/apache/airflow/pull/23106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #23106: Show warning if '/' is used in a DAG run ID
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #23106:
URL: https://github.com/apache/airflow/pull/23106#issuecomment-1103452127
Of course not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #23106: Show warning if '/' is used in a DAG run ID
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #23106:
URL: https://github.com/apache/airflow/pull/23106#issuecomment-1103444418
So this will flash a warning, but still create the dag run? We have no way to edit a run id after the fact. I wonder if we should throw an error instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23106: Show warning if '/' is used in a DAG run ID
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23106:
URL: https://github.com/apache/airflow/pull/23106#issuecomment-1105628983
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #23106: Show warning if '/' is used in a DAG run ID
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #23106:
URL: https://github.com/apache/airflow/pull/23106#issuecomment-1103450344
That one I’m not sure about either. Simply prohibiting `/` feels like a regression (it only causes problems if you use the REST API to get run info), so we want to give people time to transition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #23106: Show warning if '/' is used in a DAG run ID
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #23106:
URL: https://github.com/apache/airflow/pull/23106#issuecomment-1103451657
Ok. Mind if I add some UI validation to this PR then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org