You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/03 16:44:42 UTC

[jira] [Commented] (FLINK-5808) Missing verification for setParallelism and setMaxParallelism

    [ https://issues.apache.org/jira/browse/FLINK-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953775#comment-15953775 ] 

ASF GitHub Bot commented on FLINK-5808:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/3664

    [FLINK-5808] Revert changes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink revert-5808-release12

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3664.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3664
    
----
commit 1fc36aca9eb611890c5ca14819c785924a6a66ae
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2017-04-03T16:39:43Z

    Revert "[FLINK-5808] Add proper checks in setParallelism()/setMaxParallelism()"
    
    This reverts commit 99fb80be773499907d379553010dd999214f64fb.
    
    This fix was causing more problems than it was solving.

commit af43ee29e1f3d0c8e888d0b75af2673694f22c8b
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2017-04-03T16:40:05Z

    Revert "[FLINK-5808] Move max keygroup constants to ExecutionConfig"
    
    This reverts commit d3b275f4b7d49b67013e26d1f29a065d3131c664.
    
    This fix was causing more problems than it was solving.

commit 8adb8898fa4242a8be7011d4a55d26bf0c83f75f
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2017-04-03T16:40:14Z

    Revert "[FLINK-5808] Move default parallelism to StreamingJobGraphGenerator"
    
    This reverts commit b563f0ae2e7b7233e29e03fbb2cf18b0d853c0ca.
    
    This fix was causing more problems than it was solving.

----


> Missing verification for setParallelism and setMaxParallelism
> -------------------------------------------------------------
>
>                 Key: FLINK-5808
>                 URL: https://issues.apache.org/jira/browse/FLINK-5808
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>    Affects Versions: 1.2.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.3.0, 1.2.1
>
>
> When {{setParallelism()}} is called we don't verify that it is <= than max parallelism. Likewise, when {{setMaxParallelism()}} is called we don't check that the new value doesn't clash with a previously set parallelism.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)