You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by li...@apache.org on 2022/03/11 09:27:55 UTC

[rocketmq-apis] branch main updated: Add accept message types for Partition (#14)

This is an automated email from the ASF dual-hosted git repository.

lizhanhui pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/rocketmq-apis.git


The following commit(s) were added to refs/heads/main by this push:
     new f5b7d02  Add accept message types for Partition (#14)
f5b7d02 is described below

commit f5b7d02155b59a13df19e695e9f5938957f566d0
Author: Aaron Ai <ya...@alibaba-inc.com>
AuthorDate: Fri Mar 11 17:27:43 2022 +0800

    Add accept message types for Partition (#14)
    
    * Fix typo
    
    * Add supported message types for Partition
---
 apache/rocketmq/v1/definition.proto |  3 ++-
 apache/rocketmq/v1/service.proto    | 18 +++++++++---------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/apache/rocketmq/v1/definition.proto b/apache/rocketmq/v1/definition.proto
index efc74bf..723c1e3 100644
--- a/apache/rocketmq/v1/definition.proto
+++ b/apache/rocketmq/v1/definition.proto
@@ -172,8 +172,9 @@ message Partition {
   int32 id = 2;
   Permission permission = 3;
   Broker broker = 4;
+  repeated MessageType accept_message_types = 5;
 
-  reserved 5 to 64;
+  reserved 6 to 64;
 }
 
 enum MessageType {
diff --git a/apache/rocketmq/v1/service.proto b/apache/rocketmq/v1/service.proto
index 089d5a1..185eddf 100644
--- a/apache/rocketmq/v1/service.proto
+++ b/apache/rocketmq/v1/service.proto
@@ -47,7 +47,7 @@ message ResponseCommon {
 // provided access point.
 //
 // Access points are usually the addresses of name servers, which fulfill
-// service discovery, load-balancing and other auxillary services. Name servers
+// service discovery, load-balancing and other auxiliary services. Name servers
 // receive periodic heartbeats from affiliate brokers and erase those which
 // failed to maintain alive status.
 //
@@ -406,7 +406,7 @@ message ChangeInvisibleDurationResponse {
 // errors raise, return a response with common.status.code == `INTERNAL`.
 service MessagingService {
 
-  // Querys the route entries of the requested topic in the perspective of the
+  // Queries the route entries of the requested topic in the perspective of the
   // given endpoints. On success, servers should return a collection of
   // addressable partitions. Note servers may return customized route entries
   // based on endpoints provided.
@@ -445,16 +445,16 @@ service MessagingService {
   // If the destination topic doesn't exist, returns `NOT_FOUND`.
   rpc SendMessage(SendMessageRequest) returns (SendMessageResponse) {}
 
-  // Querys the assigned partition route info of a topic for current consumer,
-  // the returned assignment result is descided by server-side load balacner.
+  // Queries the assigned partition route info of a topic for current consumer,
+  // the returned assignment result is decided by server-side load balancer.
   //
   // If the corresponding topic doesn't exist, returns `NOT_FOUND`.
-  // If the specific endpoints is emtpy, returns `INVALID_ARGUMENT`.
+  // If the specific endpoints is empty, returns `INVALID_ARGUMENT`.
   rpc QueryAssignment(QueryAssignmentRequest)
       returns (QueryAssignmentResponse) {}
 
   // Receives messages from the server in batch manner, returns a set of
-  // messages if success. The received messages should be acked or uacked after
+  // messages if success. The received messages should be acked or nacked after
   // processed.
   //
   // If the pending concurrent receive requests exceed the quota of the given
@@ -490,14 +490,14 @@ service MessagingService {
   // Commits or rollback one transactional message.
   rpc EndTransaction(EndTransactionRequest) returns (EndTransactionResponse) {}
 
-  // Querys the offset of the specific partition, returns the offset with `OK`
+  // Queries the offset of the specific partition, returns the offset with `OK`
   // if success. The message server should maintain a numerical offset for each
-  // message in a parition.
+  // message in a partition.
   rpc QueryOffset(QueryOffsetRequest) returns (QueryOffsetResponse) {}
 
   // Pulls messages from the specific partition, returns a set of messages with
   // next pull offset. The pulled messages can't be acked or nacked, while the
-  // client is responsible for manage offesets for consumer, typically update
+  // client is responsible for manage offsets for consumer, typically update
   // consume offset to local memory or a third-party storage service.
   //
   // If the pending concurrent receive requests exceed the quota of the given