You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/12/20 03:36:43 UTC
Review Request 64742: Made volume secret isolator not standalone
container aware.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64742/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Repository: mesos
Description
-------
We'll revisit this later.
Diffs
-----
src/slave/containerizer/mesos/isolators/volume/secret.hpp 4515777b59b669ed0df0a433025668f9df6dcb83
src/slave/containerizer/mesos/isolators/volume/secret.cpp e754a1b93a032b8153ba07cfb55273cf882ab9cb
Diff: https://reviews.apache.org/r/64742/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 64742: Made volume secret isolator not standalone
container aware.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64742/#review194210
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On Dec. 20, 2017, 3:36 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64742/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 3:36 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We'll revisit this later.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/secret.hpp 4515777b59b669ed0df0a433025668f9df6dcb83
> src/slave/containerizer/mesos/isolators/volume/secret.cpp e754a1b93a032b8153ba07cfb55273cf882ab9cb
>
>
> Diff: https://reviews.apache.org/r/64742/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 64742: Made volume secret isolator not standalone
container aware.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64742/#review194213
-----------------------------------------------------------
PASS: Mesos patch 64742 was successfully built and tested.
Reviews applied: `['64742']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64742
- Mesos Reviewbot Windows
On Dec. 20, 2017, 3:36 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64742/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2017, 3:36 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We'll revisit this later.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/secret.hpp 4515777b59b669ed0df0a433025668f9df6dcb83
> src/slave/containerizer/mesos/isolators/volume/secret.cpp e754a1b93a032b8153ba07cfb55273cf882ab9cb
>
>
> Diff: https://reviews.apache.org/r/64742/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>