[GitHub] [iceberg] kbendick commented on pull request #4770: Core: Accept all API warnings in master

[GitBox <gi...@apache.org>]

kbendick commented on PR #4770:
URL: https://github.com/apache/iceberg/pull/4770#issuecomment-1126801421

   > This looks good since there are only 2 warning types: `defaultSerializationChanged` and `addedToInterface`. The serialization changes are for classes without `serialVersionUID`, but Iceberg does not guarantee any compatibility for serialized objects across versions. The interface additions are also fine because these interfaces are for internal implementations. Adding methods does not break binary compatibility for people using the interfaces.
   
   We can be more specific for the changes (provide a justification for each or for generally that class of error - like methods added to interfaces is something I hope to suppress). But for now this will unblock 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org