[jira] [Commented] (PDFBOX-2847) mergeDocumentsNonSeq does not utilize scratchFile

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607874#comment-14607874 ] 

ASF subversion and git services commented on PDFBOX-2847:
---------------------------------------------------------

Commit 1688382 from [~tilman] in branch 'pdfbox/branches/1.8'
[ https://svn.apache.org/r1688382 ]

PDFBOX-2847: use scratchFile for mergeDocumentsNonSeq, as suggested by Jim deVos

> mergeDocumentsNonSeq does not utilize scratchFile
> -------------------------------------------------
>
>                 Key: PDFBOX-2847
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2847
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 1.8.9
>            Reporter: Jim deVos
>            Assignee: Tilman Hausherr
>         Attachments: pdfbox1.8.x.patch
>
>
> I noticed when merging relatively large pdfs (1gb)  that the heap would grow by at least the same amount until complete, even when I call mergeDocumentsNonSeq() and supplying a read/write scratchfile.   
> When I looked at the source for mergeDocuments(bool, RandomAccess),  it looks like the scratch file is never used.
> {code}
> private void mergeDocuments(boolean isNonSeq, RandomAccess scratchFile) 
>             throws IOException, COSVisitorException
> {
> //...snip
>                 if (isNonSeq)
>                 {
>                     source = PDDocument.loadNonSeq(sourceFile, null);
>                 }
> //...snip
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org