You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/05/01 16:52:06 UTC
[GitHub] [incubator-iceberg] waterlx opened a new issue #994: WrappedPositionAccessor is not generated but Position2Accessor
waterlx opened a new issue #994:
URL: https://github.com/apache/incubator-iceberg/issues/994
When trying to partition on a field of StringType within a NestedType
```
Schema schema = new Schema(
Types.NestedField.required(1, "int", Types.IntegerType.get()),
Types.NestedField.required(2, "struct", Types.StructType.of(
Types.NestedField.required(5, "string", Types.StringType.get())
))
);
PartitionSpec partitionSpec = PartitionSpec.builderFor(schema).identity("struct.string").build();
```
The accessor seems not generated corrently. WrappedPositionAccessor is expected but Position2Accessor is generated instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] waterlx commented on issue #994: WrappedPositionAccessor is not generated but Position2Accessor
Posted by GitBox <gi...@apache.org>.
waterlx commented on issue #994:
URL: https://github.com/apache/incubator-iceberg/issues/994#issuecomment-622473506
To fix that, do we need to be more strict to exclude the sub-class of PositionAccessor when routing to build Position2Accessor?
Accessors and #983 seems have the same issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] waterlx closed issue #994: WrappedPositionAccessor is not generated but Position2Accessor
Posted by GitBox <gi...@apache.org>.
waterlx closed issue #994:
URL: https://github.com/apache/incubator-iceberg/issues/994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on issue #994: WrappedPositionAccessor is not generated but Position2Accessor
Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #994:
URL: https://github.com/apache/incubator-iceberg/issues/994#issuecomment-622536889
Yes, I think you're right. One solution is to not wrap the specialized accessors. We may also be able to keep a transform function so that it is applied by the outer-most accessor. That would keep the two concerns separate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] waterlx commented on issue #994: WrappedPositionAccessor is not generated but Position2Accessor
Posted by GitBox <gi...@apache.org>.
waterlx commented on issue #994:
URL: https://github.com/apache/incubator-iceberg/issues/994#issuecomment-633775757
I am about to close this issue as PR #1013 is merged into master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] waterlx commented on issue #994: WrappedPositionAccessor is not generated but Position2Accessor
Posted by GitBox <gi...@apache.org>.
waterlx commented on issue #994:
URL: https://github.com/apache/incubator-iceberg/issues/994#issuecomment-622475299
@rdblue Does it make sense to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org