You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Dariusz Kordonski (JIRA)" <de...@velocity.apache.org> on 2009/03/19 14:35:51 UTC

[jira] Created: (VELOCITY-713) FileResourceLoader does not conform to its spec

FileResourceLoader does not conform to its spec
-----------------------------------------------

                 Key: VELOCITY-713
                 URL: https://issues.apache.org/jira/browse/VELOCITY-713
             Project: Velocity
          Issue Type: Bug
    Affects Versions: 1.7
         Environment: Checked in source code of HEAD
            Reporter: Dariusz Kordonski
            Priority: Minor


The JavaDoc for org.apache.velocity.runtime.resource.loader.FileResourceLoader says:
' A loader for templates stored on the file system.  Treats the template
 as relative to the configured root path.  If the root path is empty
 treats the template name as an absolute path.'

The functionality of trying to resolve name as absolute path in case no root paths are configured is not implemented. Additionally, I suggest implementing new feature - a kind of configuration flag 'useAsAbsolutePath' that would trigger resolving resource name as absolute path, no matter if additional roots for given loader were configured. Sorry for not putting it under separate JIRA issue, it's only my suggestion and it's related to the reported bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Updated: (VELOCITY-713) FileResourceLoader does not conform to its spec

Posted by "Dariusz Kordonski (JIRA)" <de...@velocity.apache.org>.
     [ https://issues.apache.org/jira/browse/VELOCITY-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dariusz Kordonski updated VELOCITY-713:
---------------------------------------

    Component/s: Engine

> FileResourceLoader does not conform to its spec
> -----------------------------------------------
>
>                 Key: VELOCITY-713
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-713
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.7
>         Environment: Checked in source code of HEAD
>            Reporter: Dariusz Kordonski
>            Priority: Minor
>
> The JavaDoc for org.apache.velocity.runtime.resource.loader.FileResourceLoader says:
> ' A loader for templates stored on the file system.  Treats the template
>  as relative to the configured root path.  If the root path is empty
>  treats the template name as an absolute path.'
> The functionality of trying to resolve name as absolute path in case no root paths are configured is not implemented. Additionally, I suggest implementing new feature - a kind of configuration flag 'useAsAbsolutePath' that would trigger resolving resource name as absolute path, no matter if additional roots for given loader were configured. Sorry for not putting it under separate JIRA issue, it's only my suggestion and it's related to the reported bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


[jira] Commented: (VELOCITY-713) FileResourceLoader does not conform to its spec

Posted by "Will Glass-Husain (JIRA)" <de...@velocity.apache.org>.
    [ https://issues.apache.org/jira/browse/VELOCITY-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767094#action_12767094 ] 

Will Glass-Husain commented on VELOCITY-713:
--------------------------------------------

Dariusz -- 

sorry for responding late to this old bug.  Are you sure about this?  There's a unit test on this.  See AbsoluteFileResourceLoaderTestCase.

Can you provide some sample code that should work but doesn't?  If so, we can fix this.



> FileResourceLoader does not conform to its spec
> -----------------------------------------------
>
>                 Key: VELOCITY-713
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-713
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.7
>         Environment: Checked in source code of HEAD
>            Reporter: Dariusz Kordonski
>            Priority: Minor
>
> The JavaDoc for org.apache.velocity.runtime.resource.loader.FileResourceLoader says:
> ' A loader for templates stored on the file system.  Treats the template
>  as relative to the configured root path.  If the root path is empty
>  treats the template name as an absolute path.'
> The functionality of trying to resolve name as absolute path in case no root paths are configured is not implemented. Additionally, I suggest implementing new feature - a kind of configuration flag 'useAsAbsolutePath' that would trigger resolving resource name as absolute path, no matter if additional roots for given loader were configured. Sorry for not putting it under separate JIRA issue, it's only my suggestion and it's related to the reported bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org