[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1210: [HUDI-458] Redo hudi-hadoop-mr log statements using SLF4J

[GitBox <gi...@apache.org>]

lamber-ken commented on a change in pull request #1210: [HUDI-458] Redo hudi-hadoop-mr log statements using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1210#discussion_r365572725
 
 

 ##########
 File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieParquetRealtimeInputFormat.java
 ##########
 @@ -210,7 +210,7 @@ private static Configuration cleanProjectionColumnIds(Configuration conf) {
     if (!columnIds.isEmpty() && columnIds.charAt(0) == ',') {
       conf.set(ColumnProjectionUtils.READ_COLUMN_IDS_CONF_STR, columnIds.substring(1));
       if (LOG.isDebugEnabled()) {
-        LOG.debug("The projection Ids: {" + columnIds + "} start with ','. First comma is removed");
+        LOG.debug("The projection Ids: {{}} start with ','. First comma is removed", columnIds);
 
 Review comment:
   Hi @wangxianghu, may is `[` `]` is better, example:
   ```
   LOG.debug("The projection Ids: [{}] start with ','. First comma is removed", columnIds);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services