You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2024/02/27 01:58:39 UTC

[PR] [CELEBORN-1282][FOLLOWUP] Introduce ReplicateDataFailNonCriticalCauseCount metric in Grafana dashboard [incubator-celeborn]

SteNicholas opened a new pull request, #2332:
URL: https://github.com/apache/incubator-celeborn/pull/2332

   ### What changes were proposed in this pull request?
   
   Introduce `ReplicateDataFailNonCriticalCauseCount` metric in Grafana dashboard. Follow up #2323.
   
   ### Why are the changes needed?
   
   `ReplicateDataFailNonCriticalCauseCount` metric should support in Grafana dashboard with `celeborn-dashboard.json`.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   - [Celeborn Dashboard](https://stenicholas.grafana.net/d/U_qgru_7z/celeborn?orgId=1&refresh=5s)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1282][FOLLOWUP] Introduce ReplicateDataFailNonCriticalCauseCount metric in Grafana dashboard [incubator-celeborn]

Posted by "lyy-pineapple (via GitHub)" <gi...@apache.org>.
lyy-pineapple commented on PR #2332:
URL: https://github.com/apache/incubator-celeborn/pull/2332#issuecomment-1965674962

   thanks for your addition!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1282][FOLLOWUP] Introduce ReplicateDataFailNonCriticalCauseCount metric in Grafana dashboard [incubator-celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2332: [CELEBORN-1282][FOLLOWUP] Introduce ReplicateDataFailNonCriticalCauseCount metric in Grafana dashboard
URL: https://github.com/apache/incubator-celeborn/pull/2332


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1282][FOLLOWUP] Introduce ReplicateDataFailNonCriticalCauseCount metric in Grafana dashboard [incubator-celeborn]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2332:
URL: https://github.com/apache/incubator-celeborn/pull/2332#issuecomment-1965665562

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 48.87%. Comparing base [(`f4bc87e`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/f4bc87e6dbe6bb280d0e5771abad0e9353597c1e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`53f459b`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2332?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@           Coverage Diff           @@
   ##             main    #2332   +/-   ##
   =======================================
     Coverage   48.87%   48.87%           
   =======================================
     Files         207      207           
     Lines       12946    12946           
     Branches     1113     1113           
   =======================================
     Hits         6326     6326           
     Misses       6215     6215           
     Partials      405      405           
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2332?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org