[GitHub] [accumulo] milleruntime commented on pull request #2279: Improve fetchScans in Monitor

[GitBox <gi...@apache.org>]

milleruntime commented on pull request #2279:
URL: https://github.com/apache/accumulo/pull/2279#issuecomment-923297372


   > Was this code added because the TServer was reporting scans that were not actively running?
   
   It was a part of the initial creation of the method. The method was added to do the opposite (report long running scans) to help debug bigger problems with a cluster in commit 7f329a9c4dbf6f249a14a1f4bde43f261bf12875. See https://issues.apache.org/jira/browse/ACCUMULO-2645. But the code to age off old scans isn't thread safe and I am not sure why you would just remove a scan only 5 minutes later after reporting it. If an admin doesn't see the scan in that window, its useless to put it on the monitor. If there are long running scans being returned than I think they should get displayed. It is disingenuous to report no scans running if there are.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org