You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Steve Moist via Review Board <no...@reviews.apache.org> on 2017/11/09 17:07:22 UTC
Review Request 63704: SENTRY-1662 Constants java uses mutable
collection
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63704/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1662
https://issues.apache.org/jira/browse/SENTRY-1662
Repository: sentry
Description
-------
Changes the hash maps to be unmodifable maps.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 2e71ce02
Diff: https://reviews.apache.org/r/63704/diff/1/
Testing
-------
Unit tests ran.
Thanks,
Steve Moist
Re: Review Request 63704: SENTRY-1662 Constants java uses mutable
collection
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63704/
-----------------------------------------------------------
(Updated Nov. 9, 2017, 9:03 p.m.)
Review request for sentry.
Bugs: SENTRY-1662
https://issues.apache.org/jira/browse/SENTRY-1662
Repository: sentry
Description (updated)
-------
Changes the hash maps to be immutable maps.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 2e71ce02
Diff: https://reviews.apache.org/r/63704/diff/2/
Testing
-------
Unit tests ran.
Thanks,
Steve Moist
Re: Review Request 63704: SENTRY-1662 Constants java uses mutable
collection
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63704/#review190635
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On Nov. 9, 2017, 7:32 p.m., Steve Moist wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63704/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2017, 7:32 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1662
> https://issues.apache.org/jira/browse/SENTRY-1662
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Changes the hash maps to be unmodifable maps.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 2e71ce02
>
>
> Diff: https://reviews.apache.org/r/63704/diff/2/
>
>
> Testing
> -------
>
> Unit tests ran.
>
>
> Thanks,
>
> Steve Moist
>
>
Re: Review Request 63704: SENTRY-1662 Constants java uses mutable
collection
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63704/#review190637
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Nov. 9, 2017, 7:32 p.m., Steve Moist wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63704/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2017, 7:32 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1662
> https://issues.apache.org/jira/browse/SENTRY-1662
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Changes the hash maps to be unmodifable maps.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 2e71ce02
>
>
> Diff: https://reviews.apache.org/r/63704/diff/2/
>
>
> Testing
> -------
>
> Unit tests ran.
>
>
> Thanks,
>
> Steve Moist
>
>
Re: Review Request 63704: SENTRY-1662 Constants java uses mutable
collection
Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63704/
-----------------------------------------------------------
(Updated Nov. 9, 2017, 7:32 p.m.)
Review request for sentry.
Bugs: SENTRY-1662
https://issues.apache.org/jira/browse/SENTRY-1662
Repository: sentry
Description
-------
Changes the hash maps to be unmodifable maps.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/util/Constants.java 2e71ce02
Diff: https://reviews.apache.org/r/63704/diff/2/
Changes: https://reviews.apache.org/r/63704/diff/1-2/
Testing
-------
Unit tests ran.
Thanks,
Steve Moist