[GitHub] ZhennanQin commented on a change in pull request #13729: [Don't merge] check CI

[GitBox <gi...@apache.org>]

ZhennanQin commented on a change in pull request #13729: [Don't merge] check CI
URL: https://github.com/apache/incubator-mxnet/pull/13729#discussion_r244435328
 
 

 ##########
 File path: src/operator/convolution_v1-inl.h
 ##########
 @@ -335,10 +335,10 @@ class ConvolutionV1Op : public Operator {
                                      oshape[2] * oshape[3]);
     // param_.workspace is in elements of sizeof(DType)
     // if param_.workspace is set to zero the nstep_ equals ishape[0] (batch)
-    nstep_ = std::max<index_t>(
-        std::min(static_cast<index_t>(param_.workspace) /
-          (shape_colunit_.Size() + shape_dstunit_.Size()), ishape[0]),
-      1);
+    nstep_ = std::max(std::min(static_cast<index_t>(param_.workspace / (shape_colunit_.Size() +
 
 Review comment:
   Because that code can't be compiled,  compiler will throw error about type mismatch. Then I rolled back before your commit, and make some change based on that. I will move index_t out in final version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services