[GitHub] [incubator-pagespeed-mod] Lofesa opened a new pull request #1886: remove id attributes from styles

[GitBox <gi...@apache.org>]

Lofesa opened a new pull request #1886: remove id attributes from styles
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1886
 
 
   To solve this issue: prioritize critical css need to remove id attributes apache#1878
   When inlined styles have ID´s if prioritize critical css filter is used, when pagespeed restores the inlined styles from class name psa_add_styles, the ID´s become duplicate.
   The changes in this js file deletes the ID´s from these restored styles.
   These change is not the best approach, i know, cause it add more work in the browser side, maybe some user use the ID´s to make changes to the DOM and maybe the elements the user will change don´t exists, cause the styles with the ID´s are the optimized ones.
   But this is a workaround for these user that don´t do changes in styles DOM by the ID. 
   Wordpress put an ID in all inlined styles by the hook wp_add_inline_style( $handle, $data ) where the $handle become the ID and is mandatory.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services