You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/07/21 14:32:53 UTC
Review Request 61033: Added missing metrics to tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61033/
-----------------------------------------------------------
Review request for mesos, Armand Grillet and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166
src/tests/slave_tests.cpp e1cc96dbb279aea998b99779ee1b55e96fee4e41
Diff: https://reviews.apache.org/r/61033/diff/1/
Testing
-------
See https://reviews.apache.org/r/61034/
Thanks,
Alexander Rukletsov
Re: Review Request 61033: Added missing metrics to tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61033/#review181743
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 28, 2017, 2:40 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61033/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 2:40 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166
> src/tests/slave_tests.cpp a089cc47eae41cd6baeffd3f4a7ee7c7984aacbd
>
>
> Diff: https://reviews.apache.org/r/61033/diff/2/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/61030/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61033: Added missing metrics to tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61033/
-----------------------------------------------------------
(Updated July 28, 2017, 2:40 p.m.)
Review request for mesos, Armand Grillet and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166
src/tests/slave_tests.cpp a089cc47eae41cd6baeffd3f4a7ee7c7984aacbd
Diff: https://reviews.apache.org/r/61033/diff/2/
Changes: https://reviews.apache.org/r/61033/diff/1-2/
Testing (updated)
-------
See https://reviews.apache.org/r/61030/
Thanks,
Alexander Rukletsov
Re: Review Request 61033: Added missing metrics to tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On July 25, 2017, 10:12 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp
> > Line 1364 (original), 1365 (patched)
> > <https://reviews.apache.org/r/61033/diff/1/?file=1780702#file1780702line1365>
> >
> > I see that you sneaked in a style fix here. Please avoid when possible.
I felt creating a separate review for this style fix is not justified in this case. However, this is a matter of taste. Will file a separate review.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61033/#review181396
-----------------------------------------------------------
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61033/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166
> src/tests/slave_tests.cpp e1cc96dbb279aea998b99779ee1b55e96fee4e41
>
>
> Diff: https://reviews.apache.org/r/61033/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/61034/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61033: Added missing metrics to tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61033/#review181396
-----------------------------------------------------------
src/tests/slave_tests.cpp
Line 1364 (original), 1365 (patched)
<https://reviews.apache.org/r/61033/#comment256930>
I see that you sneaked in a style fix here. Please avoid when possible.
- Vinod Kone
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61033/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166
> src/tests/slave_tests.cpp e1cc96dbb279aea998b99779ee1b55e96fee4e41
>
>
> Diff: https://reviews.apache.org/r/61033/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/61034/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61033: Added missing metrics to tests.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61033/#review181175
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On July 21, 2017, 2:32 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61033/
> -----------------------------------------------------------
>
> (Updated July 21, 2017, 2:32 p.m.)
>
>
> Review request for mesos, Armand Grillet and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp e3ccf8ce32d7314e6003798404a43b2f1e83a166
> src/tests/slave_tests.cpp e1cc96dbb279aea998b99779ee1b55e96fee4e41
>
>
> Diff: https://reviews.apache.org/r/61033/diff/1/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/61034/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>