You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Holger Schimanski (JIRA)" <de...@myfaces.apache.org> on 2006/07/11 08:12:31 UTC

[jira] Created: (TOMAHAWK-530) imageLocation of inputCalendar does not work

imageLocation of inputCalendar does not work
--------------------------------------------

         Key: TOMAHAWK-530
         URL: http://issues.apache.org/jira/browse/TOMAHAWK-530
     Project: MyFaces Tomahawk
        Type: Bug

  Components: Calendar  
    Versions: 1.1.3    
    Reporter: Holger Schimanski


Setting e.g. imageLocation="images/calendar" has no effect. Images are still loaded from Extension Filter and not from the URL, which is set in imageLocation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (TOMAHAWK-530) imageLocation of inputCalendar does not work

Posted by "Holger Schimanski (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-530?page=comments#action_12445521 ] 
            
Holger Schimanski commented on TOMAHAWK-530:
--------------------------------------------

I got a patch by private email from another MyFaces user. Maybe you can use this code to solve this issue. 

In HtmlCalendarRenderer method getLocalizedLanguageScript replace

         StringBuffer script = new StringBuffer();
         setStringVariable(script,popupCalendarVariable 
         +".initData.imgDir",(JavascriptUtils.encodeString(AddResourceFactory.getInstance
         (facesContext).getResourceUri(facesContext, HtmlCalendarRenderer.class, "DB/"))));

by

         StringBuffer script = new StringBuffer();
         String imageLocation = HtmlRendererUtils.getImageLocation(uiComponent);
         if(imageLocation == null)
             setStringVariable(script,popupCalendarVariable +".initData.imgDir",
                    (JavascriptUtils.encodeString(AddResourceFactory.getInstance(facesContext)
                             .getResourceUri(facesContext, HtmlCalendarRenderer.class, "DB/"))));
         else
             setStringVariable(script, popupCalendarVariable +".initData.imgDir",
                    (JavascriptUtils.encodeString(AddResourceFactory.getInstance(facesContext)
                             .getResourceUri(facesContext, imageLocation+"/"))) );


and in getScriptBtn replace 

             String imgUrl = (String) uiComponent.getAttributes().get("popupButtonImageUrl");

             if(imgUrl!=null)
             {
                 writer.writeAttribute(HTML.SRC_ATTR, addResource.getResourceUri(facesContext, imgUrl), null);
             }
             else
             {
                 writer.writeAttribute(HTML.SRC_ATTR, addResource.getResourceUri(facesContext, HtmlCalendarRenderer.class, "images/calendar.gif"), null);
             }

by this code

             String imgUrl = (String) uiComponent.getAttributes().get("popupButtonImageUrl");
             String imageLocation = HtmlRendererUtils.getImageLocation(uiComponent);
             if(imgUrl!=null)
             {
                 writer.writeAttribute(HTML.SRC_ATTR, addResource.getResourceUri(facesContext, imgUrl), null);
             }
             else if (imageLocation != null)
             {
                 writer.writeAttribute(HTML.SRC_ATTR, addResource.getResourceUri(facesContext, imageLocation+"/calendar.gif"), null);
             }
             else
             {
                 writer.writeAttribute(HTML.SRC_ATTR, addResource.getResourceUri(facesContext, HtmlCalendarRenderer.class, "images/calendar.gif"), null);
             }



> imageLocation of inputCalendar does not work
> --------------------------------------------
>
>                 Key: TOMAHAWK-530
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-530
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Calendar
>    Affects Versions: 1.1.3
>            Reporter: Holger Schimanski
>
> Setting e.g. imageLocation="images/calendar" has no effect. Images are still loaded from Extension Filter and not from the URL, which is set in imageLocation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (TOMAHAWK-530) imageLocation of inputCalendar does not work

Posted by "Grant Smith (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Smith updated TOMAHAWK-530:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.7-SNAPSHOT
           Status: Resolved  (was: Patch Available)

Patch applied. Thanks !

> imageLocation of inputCalendar does not work
> --------------------------------------------
>
>                 Key: TOMAHAWK-530
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-530
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Calendar
>    Affects Versions: 1.1.3
>            Reporter: Holger Schimanski
>            Assignee: Grant Smith
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: patch, patch
>
>
> Setting e.g. imageLocation="images/calendar" has no effect. Images are still loaded from Extension Filter and not from the URL, which is set in imageLocation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TOMAHAWK-530) imageLocation of inputCalendar does not work

Posted by "Sascha Majunke (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-530?page=all ]

Sascha Majunke updated TOMAHAWK-530:
------------------------------------

    Status: Patch Available  (was: Open)

> imageLocation of inputCalendar does not work
> --------------------------------------------
>
>                 Key: TOMAHAWK-530
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-530
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Calendar
>    Affects Versions: 1.1.3
>            Reporter: Holger Schimanski
>
> Setting e.g. imageLocation="images/calendar" has no effect. Images are still loaded from Extension Filter and not from the URL, which is set in imageLocation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-530) imageLocation of inputCalendar does not work

Posted by "David Van Keer (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508806 ] 

David Van Keer commented on TOMAHAWK-530:
-----------------------------------------

Supplied patch seems to work nicely. Building a custom jar file for customizing the images of the input calender is somewhat of a big hassle for some most users to do. Would be nice to see this issue resolved in a future release.

> imageLocation of inputCalendar does not work
> --------------------------------------------
>
>                 Key: TOMAHAWK-530
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-530
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Calendar
>    Affects Versions: 1.1.3
>            Reporter: Holger Schimanski
>         Attachments: patch, patch
>
>
> Setting e.g. imageLocation="images/calendar" has no effect. Images are still loaded from Extension Filter and not from the URL, which is set in imageLocation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TOMAHAWK-530) imageLocation of inputCalendar does not work

Posted by "Paul Pogonyshev (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-530?page=all ]

Paul Pogonyshev updated TOMAHAWK-530:
-------------------------------------

    Status: Patch Available  (was: Open)

> imageLocation of inputCalendar does not work
> --------------------------------------------
>
>                 Key: TOMAHAWK-530
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-530
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Calendar
>    Affects Versions: 1.1.3
>            Reporter: Holger Schimanski
>
> Setting e.g. imageLocation="images/calendar" has no effect. Images are still loaded from Extension Filter and not from the URL, which is set in imageLocation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (TOMAHAWK-530) imageLocation of inputCalendar does not work

Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-530?page=all ]

Mike Kienenberger updated TOMAHAWK-530:
---------------------------------------

    Status: Open  (was: Patch Available)

> imageLocation of inputCalendar does not work
> --------------------------------------------
>
>                 Key: TOMAHAWK-530
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-530
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Calendar
>    Affects Versions: 1.1.3
>            Reporter: Holger Schimanski
>
> Setting e.g. imageLocation="images/calendar" has no effect. Images are still loaded from Extension Filter and not from the URL, which is set in imageLocation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira