You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/11/30 14:11:55 UTC

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #945: MINIFICPP-1416 - Upgrade rocksdb and build on VS2019

arpadboda commented on a change in pull request #945:
URL: https://github.com/apache/nifi-minifi-cpp/pull/945#discussion_r532624581



##########
File path: CMakeLists.txt
##########
@@ -90,17 +90,17 @@ set_property(CACHE STRICT_GSL_CHECKS PROPERTY STRINGS ${STRICT_GSL_CHECKS_Values
 # Use ccache if present
 find_program(CCACHE_FOUND ccache)
 if(CCACHE_FOUND)
-    set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache)
-    set_property(GLOBAL PROPERTY RULE_LAUNCH_LINK ccache)
-    message("-- Found ccache: ${CCACHE_FOUND}")
+	set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache)

Review comment:
       Spaces has been replaced with tabs in this file, I think we should stay with spaces. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org