[GitHub] [nifi] ottobackwards commented on a change in pull request #5458: NIFI-7865 amqp$header is splitted in the wrong way for "," and "}"

[GitBox <gi...@apache.org>]

ottobackwards commented on a change in pull request #5458:
URL: https://github.com/apache/nifi/pull/5458#discussion_r735700480



##########
File path: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##########
@@ -510,4 +514,20 @@ public static String toTitleCase(String input) {
                 .map(word -> Character.toTitleCase(word.charAt(0)) + word.substring(1))
                 .collect(Collectors.joining(" "));
     }
+
+    public static String escapeString(String str, char escapeChar, char charToEscape) {
+        if (str == null) {

Review comment:
       This check should be null or empty so that we don't do extra work for empty strings.
   pseudo 
   ```
   if str is null or empty
      return str
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org