[jira] [Updated] (LUCENE-4691) Facet tests should randomly pick IntEncoder and other stuff

["Shai Erera (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-4691:
-------------------------------

    Attachment: LUCENE-4691.patch

Patch adds FacetTestCase and now all facet tests extend it. Unfortunately, not all encoders support partitions at the moment, so for now tests that rely on partitions do not draw CLP at random. However the res of the tests, were it made sense, do.
                
> Facet tests should randomly pick IntEncoder and other stuff
> -----------------------------------------------------------
>
>                 Key: LUCENE-4691
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4691
>             Project: Lucene - Core
>          Issue Type: Test
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-4691.patch
>
>
> Facets have many encoders already, but only one of them is tested by all facet tests (the default). While {{EncodingTest}} covers all encoders, I already fixed it because it didn't catch a bug where one encoder didn't reset the given {{BytesRef}}. It will be useful if tests could choose a randomCategoryListParams(), or randomFacetIndexingParams() etc., to swap in random encoders.
> Also, I wrote an AssertingCategoryListIterator which asserts all kind of things (e.g. that if setNextReader returns false, getOrdinals isn't called). Would be good to use it by all tests.
> To do that, I think that it would be best if all facet tests extend a FacetTestCase with such utility methods.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org