[GitHub] [spark] gengliangwang commented on a diff in pull request #36137: [SPARK-38829][SQL][3.3] Remove TimestampNTZ type support in Parquet for Spark 3.3

[GitBox <gi...@apache.org>]

gengliangwang commented on code in PR #36137:
URL: https://github.com/apache/spark/pull/36137#discussion_r846989194


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala:
##########
@@ -487,7 +488,8 @@ private[parquet] class ParquetRowConverter(
     parquetType.asPrimitiveType().getPrimitiveTypeName == INT64 &&
       parquetType.getLogicalTypeAnnotation.isInstanceOf[TimestampLogicalTypeAnnotation] &&
       !parquetType.getLogicalTypeAnnotation
-        .asInstanceOf[TimestampLogicalTypeAnnotation].isAdjustedToUTC
+        .asInstanceOf[TimestampLogicalTypeAnnotation].isAdjustedToUTC &&
+      Utils.isTesting

Review Comment:
   @cloud-fan Since we decided to release NTZ in 3.4 version, there should not be TODO in 3.3 code base.
   We can have a simple comment like 
   ```
   // SPARK-38829: Remove TimestampNTZ type support in Parquet for Spark 3.3
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org