[GitHub] [incubator-kyuubi] turboFei commented on pull request #2892: [KYUUBI #2628][FOLLOWUP] Reuse the kyuubi-ctl batch commands for SubmitBatchCommand

[GitBox <gi...@apache.org>]

turboFei commented on PR #2892:
URL: https://github.com/apache/incubator-kyuubi/pull/2892#issuecomment-1157502474

   > I agree that we need to reuse the code in CreateBatchCommand and LogBatchCommand for submit batch operation. But I am wondering if it is necessary to add a BatchCommand.
   > 
   > I think the main point is that we need to separate the calling api(do Run) part and the render part. Currently, those are stuck together in run() method.
   > 
   > For all the Command, the operation is: validate, doRun, and render. We could separate the current run() method into doRun and render. We could let doRun return object, and let render print the object. It will apply to all kinds of resources. So we could do it in Command.scala instead of adding a new BatchCommand.scala?
   
   thanks @lightning-L  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org