You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/24 12:55:32 UTC
[GitHub] [kafka] kamalcph opened a new pull request #10202: MINOR: Changed the batch-size description as unused in console producer.
kamalcph opened a new pull request #10202:
URL: https://github.com/apache/kafka/pull/10202
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10202: MINOR: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-787891934
> Is there a JIRA/KIP where this deprecation was discussed?
No, I don't find any. The batch size config is unused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-802157373
Can we deprecate this config in 2.8 if allowed and remove it in the 3.0 release? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-1059924588
Closing this PR, as it's addressed in #11517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph edited a comment on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph edited a comment on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-806380925
@chia7712 @tombentley
Can you comment/upvote on the KIP to deprecate this config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-801286324
> its unused since 2.0 release. it looks like we just forgot this config, when we removed old producer code. I think we dont require KIP for this. we can remove the unused config option.
Does it produce error if users input `batch-size` (after we remove the config)? If so, it seems to me the deprecation cycle is requisite as removing the argument could break something (even though the config is unused).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-787919773
Filed [KAFKA-12392](https://issues.apache.org/jira/browse/KAFKA-12392) ticket and opened [KIP-717](https://cwiki.apache.org/confluence/x/DB1RCg) for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] tombentley commented on pull request #10202: MINOR: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-787888644
Is there a JIRA/KIP where this deprecation was discussed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph edited a comment on pull request #10202: MINOR: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph edited a comment on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-787891934
> Is there a JIRA/KIP where this deprecation was discussed?
No, I don't find any and it wasn't discussed. The config is unused so I propose to deprecate it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph closed pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph closed pull request #10202:
URL: https://github.com/apache/kafka/pull/10202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-806380925
@chia7712
Can you comment/upvote on the KIP to deprecate this config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-794187462
@chia7712 Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph edited a comment on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
kamalcph edited a comment on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-787919773
Filed [KAFKA-12392](https://issues.apache.org/jira/browse/KAFKA-12392) ticket and opened [KIP-717](https://cwiki.apache.org/confluence/x/DB1RCg) for discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] omkreddy edited a comment on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
omkreddy edited a comment on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-801279341
its unused since 2.0 release. it looks like we just forgot this config, when we removed old producer code. I think we dont require KIP for this. maybe we can remove the unused config option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] omkreddy commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
omkreddy commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-801279341
its unused since 2.0 release. it looks like we just forgot this config, when we removed old producer code. I think we dont require KIP for this. we can remove the unused config option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10202:
URL: https://github.com/apache/kafka/pull/10202#issuecomment-794906679
@kamalcph thanks for filing KIP. noted that KIP must be accepted first :)
see https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org