You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/06 13:23:07 UTC
[GitHub] [skywalking] liqiangz opened a new issue #6906: Support ignore server-side some failed HTTP status code.
liqiangz opened a new issue #6906:
URL: https://github.com/apache/skywalking/issues/6906
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [x] Requirement
- [ ] Feature or performance improvement
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
Now the http request regards all requests with http status code >= 400 as failed. But as a http server, we often use 403 as the status code of not logged in. In some other scenarios , we do not want the 404 or 405 status code to interfere with the statistics of the successful rate.
Maybe We can support `statuscheck.ignored_server-side_http_status_code` in agent configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #6906:
URL: https://github.com/apache/skywalking/issues/6906#issuecomment-833537763
> > > > If you insist on your response code, use `responseCode` in the OAL to calculate the successful rate.
> > >
> > >
> > > But now in the agent, the httpcode above 400 is regarded as a failure. There are some scenarios, such as 404 and other codes, which are not regarded as failures.
> >
> >
> > So what? OAL is the one determining the metrics, which is your question.
>
> Thanks for your reply. Using oal is a good idea, the disadvantage is that it will affect all agents. But it is enough for me now.
You could target specific services if you want. But after all, it is little performance impact, and keep in your private version only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6906:
URL: https://github.com/apache/skywalking/issues/6906#issuecomment-833526364
If you insist on your response code, use `responseCode` in the OAL to calculate the successful rate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on issue #6906:
URL: https://github.com/apache/skywalking/issues/6906#issuecomment-833530198
> If you insist on your response code, use `responseCode` in the OAL to calculate the successful rate.
But now in the agent, the httpcode above 400 is regarded as a failure. There are some scenarios, such as 404 and other codes, which are not regarded as failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on issue #6906:
URL: https://github.com/apache/skywalking/issues/6906#issuecomment-833534856
> > > If you insist on your response code, use `responseCode` in the OAL to calculate the successful rate.
> >
> >
> > But now in the agent, the httpcode above 400 is regarded as a failure. There are some scenarios, such as 404 and other codes, which are not regarded as failures.
>
> So what? OAL is the one determining the metrics, which is your question.
Thanks for your reply. Using oal is a good idea, the disadvantage is that it will affect all agents. But it is enough for me now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6906:
URL: https://github.com/apache/skywalking/issues/6906#issuecomment-833531491
> > If you insist on your response code, use `responseCode` in the OAL to calculate the successful rate.
>
> But now in the agent, the httpcode above 400 is regarded as a failure. There are some scenarios, such as 404 and other codes, which are not regarded as failures.
So what? OAL is the one determining the metrics, which is your question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6906:
URL: https://github.com/apache/skywalking/issues/6906#issuecomment-833537763
> > > > If you insist on your response code, use `responseCode` in the OAL to calculate the successful rate.
> > >
> > >
> > > But now in the agent, the httpcode above 400 is regarded as a failure. There are some scenarios, such as 404 and other codes, which are not regarded as failures.
> >
> >
> > So what? OAL is the one determining the metrics, which is your question.
>
> Thanks for your reply. Using oal is a good idea, the disadvantage is that it will affect all agents. But it is enough for me now.
You could target specific services if you want. But after all, it is low-performance impact, and keep in your private version only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] liqiangz commented on issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
liqiangz commented on issue #6906:
URL: https://github.com/apache/skywalking/issues/6906#issuecomment-833528037
> > Now the http request regards all requests with http status code >= 400 as failed. But as a http server, we often use 403 as the status code of not logged in, and we don’t want to treat not being logged in as an error. In some other scenarios , we do not want the 404 or 405 status code to interfere with the statistics of the successful rate.
>
> Why isn't `not-authentication` coded as 503?
There is a lot of old code here. We cannot modify these logics. We can only be compatible with these codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6906:
URL: https://github.com/apache/skywalking/issues/6906#issuecomment-833525366
> Now the http request regards all requests with http status code >= 400 as failed. But as a http server, we often use 403 as the status code of not logged in, and we don’t want to treat not being logged in as an error. In some other scenarios , we do not want the 404 or 405 status code to interfere with the statistics of the successful rate.
Why isn't `not-authentication` coded as 503?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6906:
URL: https://github.com/apache/skywalking/issues/6906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6906: Support ignore some server-side failed HTTP status code.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6906:
URL: https://github.com/apache/skywalking/issues/6906#issuecomment-833529293
> > > Now the http request regards all requests with http status code >= 400 as failed. But as a http server, we often use 403 as the status code of not logged in, and we don’t want to treat not being logged in as an error. In some other scenarios , we do not want the 404 or 405 status code to interfere with the statistics of the successful rate.
> >
> >
> > Why isn't `not-authentication` coded as 503?
>
> There is a lot of old code here. We cannot modify these logics. We can only be compatible with these codes.
Read https://github.com/apache/skywalking/issues/6906#issuecomment-833526364. But also, you should know, we never should add features base on others' mistakes. This is not a good way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org