[GitHub] [hive] veghlaci05 commented on a diff in pull request #4200: HIVE-26827 - Add configs in error message to workaround predicate iss…

["veghlaci05 (via GitHub)" <gi...@apache.org>]

veghlaci05 commented on code in PR #4200:
URL: https://github.com/apache/hive/pull/4200#discussion_r1177869448


##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/LeafFilterFactory.java:
##########
@@ -37,6 +37,9 @@
 
 public class LeafFilterFactory {
   private static final Logger LOG = LoggerFactory.getLogger(LeafFilterFactory.class);
+  public static final String MESSAGE =

Review Comment:
   Since it is public and used outside of this class, the name could be a bit more meaningful, like TYPE_NOT_SUPPORTED_MESSAGE, or sth similar. Also @VisibleForTesting annotation should be added to explicitly mark why it is public.
   
   Another option to move the new tests in a separate test class placed in the org.apache.hadoop.hive.ql.io.parquet package. This would allow to reduce visibility to package private.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org