You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/06 03:47:04 UTC

[GitHub] [beam] Dobiasd commented on pull request #15087: [BEAM-12544] Add support for Avro timestamps in microseconds

Dobiasd commented on pull request #15087:
URL: https://github.com/apache/beam/pull/15087#issuecomment-874437043


   The tests are based on the assumption, that in the conversion chain `Avro (A) -> Beam (B) -> Avro (C)` the schema in C is the same as in A.
   
   For millisecond timestamps this works fine: `Avro (TimestampMillis) -> Beam (DATETIME) -> Avro (TimestampMillis)`
   But for microsecond timestamps it does not: `Avro (TimestampMicros) -> Beam (DATETIME) -> Avro (TimestampMillis)`
   
   Thus I've just pushed a commit that removed the (failing) tests for `TimestampMillis` again.
   
   @iemejia Do you think this pull request is good to (squash-)merge despite that lack of additional tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org