You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/05 08:04:56 UTC
[GitHub] [apisix] kouphax opened a new pull request #1998: Correct directory after cloning repo
kouphax opened a new pull request #1998:
URL: https://github.com/apache/apisix/pull/1998
The cd command after cloning the repo would fail as it is not yet in the incubator-apisix-docker directory.
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
The Getting Started steps in the documentation, if ran exactly as shown would not work. This corrects the `cd` path to that they will work.
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [X] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases? **N/A**
* [X] Have you modified the corresponding document?
* [X] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #1998: Correct directory after cloning repo
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1998:
URL: https://github.com/apache/apisix/pull/1998#discussion_r465626674
##########
File path: doc/getting-started.md
##########
@@ -52,7 +52,7 @@ This command will start the APISIX server and the admin API will be available in
```bash
$ git clone https://github.com/apache/incubator-apisix-docker.git
-$ cd example
+$ cd incubator-apisix-docker/example
Review comment:
https://github.com/apache/apisix-docker
the latest address should be this one. please update it
##########
File path: doc/zh-cn/getting-started.md
##########
@@ -50,7 +50,7 @@ Apache APISIX 可以多种操作环境中安装。[如何安装文档](how-to-bu
```bash
$ git clone https://github.com/apache/incubator-apisix-docker.git
-$ cd example
+$ cd incubator-apisix-docker/example
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #1998: Correct directory after cloning repo
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1998:
URL: https://github.com/apache/apisix/pull/1998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org