You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2015/12/01 23:04:04 UTC
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/10077
[SPARK-12079][BUILD][SQL] Run Catalyst subproject's tests in parallel
The Catalyst tests do not launch SparkContexts and thus are easy to parallelize without introducing flakiness. This is really easy to do and can save ~2 minutes per test run.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark parallel-catalyst-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10077.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10077
----
commit 12f3e3a4a46e668ce2eecb4ff3bc21657608317d
Author: Josh Rosen <jo...@databricks.com>
Date: 2015-12-01T21:59:52Z
Allow Catalyst tests to run in parallel.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161556126
**[Test build #47131 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47131/consoleFull)** for PR 10077 at commit [`12f3e3a`](https://github.com/apache/spark/commit/12f3e3a4a46e668ce2eecb4ff3bc21657608317d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10077#discussion_r46346900
--- Diff: project/SparkBuild.scala ---
@@ -671,7 +682,6 @@ object TestSettings {
}
Seq[File]()
},
- concurrentRestrictions in Global += Tags.limit(Tags.Test, 1),
--- End diff --
I think it should be okay to remove this here. The other subprojects still will not run in parallel because a) we use forking in tests and `testForkedParallel` will be false for those projects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161111630
**[Test build #47000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47000/consoleFull)** for PR 10077 at commit [`12f3e3a`](https://github.com/apache/spark/commit/12f3e3a4a46e668ce2eecb4ff3bc21657608317d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161553258
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161130453
Hmm, it looks like the Catalyst tests ended up running in parallel with the sequential runs of the other tests, meaning that the Catalyst tests should now have virtually no impact on the end-to-end time of the build. However, it looks like this means that test output also got inverleaved, making the main Jenkins logs (and possibly catalyst/unit-tests.log) harder to read.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-167848248
Closing this for now; this is blocked on an investigation into custom log appenders in tests in order to fix the log interleaving problems, as well as an investigation into the build hang issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10077#discussion_r46367987
--- Diff: project/SparkBuild.scala ---
@@ -671,7 +682,6 @@ object TestSettings {
}
Seq[File]()
},
- concurrentRestrictions in Global += Tags.limit(Tags.Test, 1),
--- End diff --
(Test comment to test something in Spark PRs)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161632526
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47131/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen closed the pull request at:
https://github.com/apache/spark/pull/10077
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10077#discussion_r46370734
--- Diff: project/SparkBuild.scala ---
@@ -671,7 +682,6 @@ object TestSettings {
}
Seq[File]()
},
- concurrentRestrictions in Global += Tags.limit(Tags.Test, 1),
--- End diff --
(Test comment for Spark PRs)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161158587
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161632524
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161632276
**[Test build #47131 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47131/consoleFull)** for PR 10077 at commit [`12f3e3a`](https://github.com/apache/spark/commit/12f3e3a4a46e668ce2eecb4ff3bc21657608317d).
* This patch **fails from timeout after a configured wait of \`250m\`**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161158535
**[Test build #47000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47000/consoleFull)** for PR 10077 at commit [`12f3e3a`](https://github.com/apache/spark/commit/12f3e3a4a46e668ce2eecb4ff3bc21657608317d).
* This patch **fails from timeout after a configured wait of \`250m\`**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:\n * ` * For example, we build an encoder for `case class Data(a: Int, b: String)` and the real type`\n * `case class UpCast(child: Expression, dataType: DataType, walkedTypePath: Seq[String])`\n * ` case class SubExprEliminationState(isNull: String, value: String)`\n * `case class InitializeJavaBean(beanInstance: Expression, setters: Map[String, Expression])`\n
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12079][BUILD][SQL] Run Catalyst subproj...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10077#issuecomment-161158588
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47000/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org