[GitHub] [arrow-datafusion] alamb opened a new issue, #3886: Make `ConfigOptions` easier to configure / set

[GitBox <gi...@apache.org>]

alamb opened a new issue, #3886:
URL: https://github.com/apache/arrow-datafusion/issues/3886

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   In order to use the `ConfigOptions` structure in more places, it was changed to be an `Arc<RwLock<ConfigOptions>>` by @waitingkuo  in https://github.com/apache/arrow-datafusion/pull/3455 which is good
   
   The usecase there was so that the configuration was owned by `SessionContext` but other parts could read it if necessary -- specifically,  `information_schema.df_settings` / `SHOW ALL` initially. 
   
   I have been trying to consolidate these settings (see https://github.com/apache/arrow-datafusion/pull/3822) but find that working with `ConfigOptions` is somewhat of a pain (as you have to type Arc<RwLock<ConfigOptions>> a bunch and then to update values you have to call `read()` and `write()`
   
   **Describe the solution you'd like**
   
   I would like to move the mutability handling into `ConfigOption` so this looks like
   
   ```rust
   #[impl(Clone)]
   struct ConfigOptions { 
     data: Arc<RwLock<...>>
   }
   ```
   
   And change all places in the code that use
   
   ```rust
   Arc<RwLock<ConfigOptions>>
   ```
   
   to 
   
   ```
   ConfigOptions
   ```
   
   That would hide the details of shared ownership more nicely I think
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold closed issue #3886: Make `ConfigOptions` easier to work with

[GitBox <gi...@apache.org>]

tustvold closed issue #3886: Make `ConfigOptions` easier to work with
URL: https://github.com/apache/arrow-datafusion/issues/3886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org