You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by manishgupta88 <gi...@git.apache.org> on 2018/03/20 05:15:05 UTC

[GitHub] carbondata pull request #2031: [CARBONDATA-2223] Adding Listener Support for...

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2031#discussion_r175657383
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java ---
    @@ -151,10 +153,10 @@ private BlockMetaInfo createBlockMetaInfo(String carbonDataFile) throws IOExcept
           }
           if (missedIdentifiers.size() > 0) {
             SegmentIndexFileStore indexFileStore = new SegmentIndexFileStore();
    -
    +        List<String> filesRead = new ArrayList<>();
    --- End diff --
    
    use Set in place of List...Set will have a better performance as compared to list as your data grows


---