You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/30 18:15:52 UTC
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13511: [BEAM-11372-11371-11369][Website revamp] Implemented community and contact us pages, navbar on mobiles
TheNeuralBit commented on a change in pull request #13511:
URL: https://github.com/apache/beam/pull/13511#discussion_r548304507
##########
File path: website/www/site/layouts/shortcodes/list_with_icons.html
##########
@@ -0,0 +1,29 @@
+{{/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License. See accompanying LICENSE file.
+ */}}
+
+ {{ $data := index $.Site.Data .Site.Language.Lang }}
+ <div class="icon-list">
+ {{ range $item := $data.community_list }}
Review comment:
Should this be a parameter to the `list_with_icons` shortcode?
##########
File path: website/www/site/data/en/community_list.yaml
##########
@@ -0,0 +1,27 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+- title: Join Beam Community
+ body: Here you will find real life cases.
+ icon: icons/community/bee-icon.svg
+- title: Contact us!
+ body: You want to know what is going on? Raise a bug? Propose a feature request? Here you will find all of them info all of the info on who to contact.
Review comment:
```suggestion
body: You want to know what is going on? Raise a bug? Propose a feature request? Here you will find all of the info on who to contact.
```
##########
File path: website/www/site/layouts/community/baseof.html
##########
@@ -11,30 +11,30 @@
*/}}
<!DOCTYPE html>
- <html lang="{{ .Site.Language.Lang }}" class="no-js">
- <head>
- {{ partial "head.html" . }}
- </head>
- <body class="body" data-spy="scroll" data-target=".page-nav" data-offset="0">
- {{ partial "header.html" . }}
- <div class="clearfix container-main-content">
- <div class="section-nav closed" data-offset-top="90" data-offset-bottom="500">
- <span class="section-nav-back glyphicon glyphicon-menu-left"></span>
- <nav>
- <ul class="section-nav-list" data-section-nav>
- {{ partial (printf "section-menu/%s/community.html" .Lang) . }}
- </ul>
- </nav>
- </div>
-
- <nav class="page-nav clearfix" data-offset-top="90" data-offset-bottom="500">
- {{ .TableOfContents }}
- </nav>
-
- <div class="body__contained body__section-nav">
- {{ .Content }}
- </div>
- </div>
- {{ partial "footer.html" . }}
- </body>
- </html>
Review comment:
nit: this looks like all whitespace changes. Can it be reverted?
##########
File path: website/www/site/content/en/community/contact-us.md
##########
@@ -20,28 +20,34 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-# Contact Us
+
+# Contact us!
+
+<br/>
There are many ways to reach the Beam user and developer communities - use
whichever one seems best.
-<!-- We use div instead of table shortcode here, because markdownify break superscripts -->
-<div class="table-wrapper">
+<br/>
+<br/>
-| How to contact us | When to use it |
-| ----------------- | ---------------|
-| [user@](https://lists.apache.org/list.html?user@beam.apache.org) mailing list | User support and questions ([Subscribe](mailto:user-subscribe@beam.apache.org)[^1], [Unsubscribe](mailto:user-unsubscribe@beam.apache.org)[^1], [Archives](https://lists.apache.org/list.html?user@beam.apache.org)) |
-| [dev@](https://lists.apache.org/list.html?dev@beam.apache.org) mailing list | Development discussions ([Subscribe](mailto:dev-subscribe@beam.apache.org)[^1], [Unsubscribe](mailto:dev-unsubscribe@beam.apache.org)[^1], [Archives](https://lists.apache.org/list.html?dev@beam.apache.org)) |
-| [commits@](https://lists.apache.org/list.html?commits@beam.apache.org) mailing list | Firehose of commits, bugs, pull requests, etc. ([Subscribe](mailto:commits-subscribe@beam.apache.org)[^1], [Unsubscribe](mailto:commits-unsubscribe@beam.apache.org)[^1], [Archives](https://lists.apache.org/list.html?commits@beam.apache.org)) |
-| [builds@](https://lists.apache.org/list.html?builds@beam.apache.org) mailing list | Firehose of build notifications from Jenkins ([Subscribe](mailto:builds-subscribe@beam.apache.org)[^1], [Unsubscribe](mailto:builds-unsubscribe@beam.apache.org)[^1], [Archives](https://lists.apache.org/list.html?builds@beam.apache.org)) |
-| [JIRA bug tracker](https://issues.apache.org/jira/browse/BEAM) | Report bugs / discover known issues |
-| [StackOverflow](https://stackoverflow.com/questions/tagged/apache-beam) | Ask and answer user support questions |
-| [Slack](https://s.apache.org/beam-slack-channel) | Chat with users and developers in the ASF Slack. Note: Please [join the #beam channel](https://s.apache.org/beam-slack-channel) after you [created an account](https://s.apache.org/slack-invite). Please do not ask Beam questions in #general. |
+## How to use mailing lists?/What is it?
+Here should be a short description on what mailing lists are and how to use them. Also information on how does subscribe, unsubscribe and archives do work (blank email etc).
Review comment:
```suggestion
TODO: Here should be a short description on what mailing lists are and how to use them. Also information on how does subscribe, unsubscribe and archives do work (blank email etc).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org