[GitHub] [flink-kubernetes-operator] Miuler commented on pull request #252: [FLINK-27889] fix: Catch the error when last reconciled spec is null

[GitBox <gi...@apache.org>]

Miuler commented on PR #252:
URL: https://github.com/apache/flink-kubernetes-operator/pull/252#issuecomment-1145875377

   > @Miuler could you please provide a detailed description of what this change does specifically and what is the error scenario that we are handling here?
   > 
   > This is a very critical and somewhat complex part of the operator logic so we should try to be aware of the full impact of these changes.
   
   Excuse me, I commente in Jira the error, 
   
   Is a real error, in my cluster, I ended up with 4 deployments in certification (UAT) but without any pod, and every time the cluster restarted it tried to delete, and then it died. Without any solution.
   
   I refactored with intention the show is the solution, but I can do a squash in a single commit.
   
   The intention is to divide it into two parts, the first to try to connect to the cluster and delete it and then delete the deployment, in order to catch the error when the last spec is null and only delete the deployment. And I use a Exception but.
   
   And use a custom exception, because you already threw a RuntimeException, I just wrapped it to distinguish it from any other JVM RuntimeException, and couldn't handle it because it would change the behavior of FlinkConfigManager#getObserveConfig which is used in several places


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org