[GitHub] merlimat commented on a change in pull request #1324: Move pulsar functions dependency version to root pom and remove duplicated license headers

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1324: Move pulsar functions dependency version to root pom and remove duplicated license headers
URL: https://github.com/apache/incubator-pulsar/pull/1324#discussion_r172056483
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -619,6 +625,37 @@ flexible messaging model and an intuitive client API.</description>
         <version>${bouncycastle.version}</version>
       </dependency>
 
+      <dependency>
+        <groupId>net.jodah</groupId>
+        <artifactId>typetools</artifactId>
+        <version>${typetools.version}</version>
+      </dependency>
+
+      <dependency>
+        <groupId>io.grpc</groupId>
+        <artifactId>grpc-all</artifactId>
+        <version>${grpc.version}</version>
+      </dependency>
+
+      <dependency>
+        <groupId>com.google.code.gson</groupId>
+        <artifactId>gson</artifactId>
+        <version>${gson.version}</version>
+      </dependency>
+
+      <dependency>
+        <groupId>com.yahoo.datasketches</groupId>
+        <artifactId>sketches-core</artifactId>
+        <version>${sketches.version}</version>
+      </dependency>
 
 Review comment:
   Can you also fix `pulsar-client/pom.xml` that is currently specifying the version for this dependency?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services