You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by aroberson <gi...@git.apache.org> on 2015/04/10 16:01:25 UTC
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
GitHub user aroberson opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102
Fixed zIndex issue on Windows 8, 8.1 where InAppBrowser opens behind def...
...ault app.
Windows 8 and 8.1 uses the www/windows8/InAppBrowserProxy.js file instead of the default. The zIndex on the browserWrap was not being set which causes the window to position behind the app calling window.open().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ABB-Austin/cordova-plugin-inappbrowser master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit 11a2acfd7b8c07ece4b03815af7b6f9b0ead318e
Author: aroberson <ad...@ventyx.abb.com>
Date: 2015-04-10T13:53:48Z
Fixed zIndex issue on Windows 8, 8.1 where InAppBrowser opens behind default app.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by napcat <gi...@git.apache.org>.
Github user napcat commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-157380781
Is this fixed? How can I fixe it?
I have the exact same problem described in the image above:
https://cloud.githubusercontent.com/assets/7433049/8339931/80bbcee4-1a91-11e5-8fe1-c6112debd384.png
I use inAppBrowser to login on facebook, google or twitter in my login screen. The inAppBrowser appears, but not fully scaled.
I'm using cordova 5.3.3 and cordova-plugin-inappbrowser 1.0.1 "InAppBrowser".
The same code works fine on a Windows Phone 8 platform (cordova add platform wp8), but not in windows platform (cordova add platform windows), the projects for windows phone 8.1 and windows 10 (universal windows) does not work as aspected (not fully scaled).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by aroberson <gi...@git.apache.org>.
Github user aroberson commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-117844703
There is nothing I can do without seeing the code. It would take a lot of time to understand what you are doing.
> On Jul 1, 2015, at 1:38 PM, icaro56 <no...@github.com> wrote:
>
>
> Now, it is like this.
>
> The css files from facebook are not working properly.
>
> SEC7117: Network request to https://fbstatic-a.akamaihd.net/rsrc.php/v2/yX/r/qVownUs0hjp.css did not succeed.
> Your application manifest does not declare the following capabilities: internetClient privateNetworkClientServer
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by aroberson <gi...@git.apache.org>.
Github user aroberson commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-115919772
No, after making the zindex change, you have have your apps css right for the content displayed.
> On Jun 26, 2015, at 6:54 AM, icaro56 <no...@github.com> wrote:
>
> aroberson,
>
> Have I change the InAppBrowserProxy.js file to solved this?
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by icaro56 <gi...@git.apache.org>.
Github user icaro56 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-118334268
Aroberson,
I send a email with the code.
thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by napcat <gi...@git.apache.org>.
Github user napcat commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-157783475
thank you sgrebnov for your time!
let me know if you found a fix for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by icaro56 <gi...@git.apache.org>.
Github user icaro56 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-118012726
aroberson, try to open this link on windows 10 emulator with window.open
https://m.facebook.com/login.php?skip_api_login=1&api_key=321311011387171&signed_next=1&next=https%3A%2F%2Fm.facebook.com%2Fv2.2%2Fdialog%2Foauth%3Fredirect_uri%3Dhttps%253A%252F%252Fwww.facebook.com%252Fconnect%252Flogin_success.html%26scope%3Demail%252Cuser_friends%252Cpublic_profile%26response_type%3Dtoken%26client_id%3D321311011387171%26ret%3Dlogin&cancel_url=https%3A%2F%2Fwww.facebook.com%2Fconnect%2Flogin_success.html%3Ferror%3Daccess_denied%26error_code%3D200%26error_description%3DPermissions%2Berror%26error_reason%3Duser_denied%23_%3D_&display=touch&_rdr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by napcat <gi...@git.apache.org>.
Github user napcat commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-159858236
Hello, purplecabbage. Thank you for the information.
I changed the css to remove the border, but I'm assuming the border serves as a way to close the in app browser (if I click in the empty area the inappbrowser closes), since there's a bug with the back button. I will wait for that fix.
thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by aroberson <gi...@git.apache.org>.
Github user aroberson commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-115462707
You have to use css and divs to get it to position in the web view or iframe properly.
> On Jun 24, 2015, at 2:53 PM, icaro56 <no...@github.com> wrote:
>
> I follow your sample. Now the window shows. But, it does not scale in screen. See the picture.
>
>
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by icaro56 <gi...@git.apache.org>.
Github user icaro56 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-157405904
Do the test on windows 10 device. It seems the emulator is broken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-159687509
The 80px border is by design. I am planning a pr to make this customizable via css.
Back button is an error, I believe there is a jira issue already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by icaro56 <gi...@git.apache.org>.
Github user icaro56 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-115655215
aroberson,
Have I change the InAppBrowserProxy.js file to solved this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-159866283
I believe we have special option (documented) for this case (fullscreen=yes) and two classes you can use to customize IAB popup look and feel (`inAppBrowserWrap` and `inAppBrowserWrapFullscreen`)
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/www/inappbrowser.css
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by eduboxgithub <gi...@git.apache.org>.
Github user eduboxgithub commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-157654302
I'm not testing in the emulator... I have an old Lumia 625 with windows 8.1 and a Lumia 640 with windows 10. In both devices the webview is not fully scaled and the image above.
If I use wp8 cordova platform it works great in both devices, but I need to upgrade the app to 8.1 at least =(
Can it be some weird css in my project? I don't think I have any specific css for the webview, at least I did not add any...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by icaro56 <gi...@git.apache.org>.
Github user icaro56 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-117791270
Now, it is like this.
The css files from facebook are not working properly.
SEC7117: Network request to https://fbstatic-a.akamaihd.net/rsrc.php/v2/yX/r/qVownUs0hjp.css did not succeed.
Your application manifest does not declare the following capabilities: internetClient privateNetworkClientServer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-157801592
@napcat please try the latest plugin version and let me know whether it works
```
cordova plugin add https://github.com/apache/cordova-plugin-inappbrowser/
```
I've been playing with re-size and it worked for me, I don't see anything wrong with InAppBrowser popup size (`box-sizing: border-box` and 100% width have been recently added to master)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by napcat <gi...@git.apache.org>.
Github user napcat commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-157654513
I'm not testing in the emulator... I have an old Lumia 625 with windows 8.1 and a Lumia 640 with windows 10. In both devices the webview is not fully scaled and the image above.
If I use wp8 cordova platform it works great in both devices, but I need to upgrade the app to 8.1 at least =(
Can it be some weird css in my project? I don't think I have any specific css for the webview, at least I did not add any...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-157709218
There are two issues here IMO:
1. The fix goes to `src/windows8`- I think we can just use `src/windows/` for `windows8` platform as well - I'll test and update `plugin.xml`
2. I think we should use `box-sizing: border-box` and `width:100%` so we don't need to calculate new width when size is changed
I'll handle this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by icaro56 <gi...@git.apache.org>.
Github user icaro56 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-114992595
I follow your sample. Now the window shows. But, it does not scale in screen. See the picture.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by icaro56 <gi...@git.apache.org>.
Github user icaro56 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-117712014
In inappbrowser's plugin.xml the src for platform Windows src/windows/InAppBrowserProxy.js does not exist. Then I change to src/windows8/InAppBrowserProxy.js.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by napcat <gi...@git.apache.org>.
Github user napcat commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-159620500
Yes... that worked! =) The inappbrowser windows is now fully scaled, but there's a border, with about 70/80px around the page. Is that supposed to happen?
Another thing... If i press the back button on the device, instead of going back to the app and close the in app browser, the hole app closes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...
Posted by icaro56 <gi...@git.apache.org>.
Github user icaro56 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-117709015
On Windows 10 it does not works. The InAppBrowserProxy.js never is called. Could you help me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org