You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "eaten-cake (via GitHub)" <gi...@apache.org> on 2025/05/20 19:24:43 UTC
[PR] [Relax][Frontend][ONNX] Fix: bitwise_not misclassified as binary (is … [tvm]
eaten-cake opened a new pull request, #18001:
URL: https://github.com/apache/tvm/pull/18001
Addresses issue https://github.com/apache/tvm/issues/17991.
This PR corrects the classification of the `bitwise_not` operation from binary to unary by modifying the `BitwiseNot` implementation class.
`BitwiseNot` previously inherited from this specific class, which was a subclass of `BinaryBase`.
https://github.com/apache/tvm/blob/ffa82b30eccab8099bd4819ddc23af0f28e2d7e7/python/tvm/relax/frontend/onnx/onnx_frontend.py#L518-L531
However, BinaryBase needs two operands in this case.
https://github.com/apache/tvm/blob/ffa82b30eccab8099bd4819ddc23af0f28e2d7e7/python/tvm/relax/frontend/onnx/onnx_frontend.py#L348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax][Frontend][ONNX] Fix: bitwise_not misclassified as binary (is … [tvm]
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy merged PR #18001:
URL: https://github.com/apache/tvm/pull/18001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax][Frontend][ONNX] Fix: bitwise_not misclassified as binary (is … [tvm]
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on PR #18001:
URL: https://github.com/apache/tvm/pull/18001#issuecomment-2896660381
Thanks for the fix, please add a regression test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relax][Frontend][ONNX] Fix: bitwise_not misclassified as binary (is … [tvm]
Posted by "eaten-cake (via GitHub)" <gi...@apache.org>.
eaten-cake commented on PR #18001:
URL: https://github.com/apache/tvm/pull/18001#issuecomment-2901204251
> Thanks for the fix, please add a regression test case
The regression tests have been added. Since the previous CI did not support opset18, I have removed the skip statements. The current tests can now cover the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org