You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/06/22 18:25:15 UTC

[Bug 56657] New: Parallel deployment. If sessionid belongs to the latest version of webapp, use the latest version.

https://issues.apache.org/bugzilla/show_bug.cgi?id=56657

            Bug ID: 56657
           Summary: Parallel deployment. If sessionid belongs to the
                    latest version of webapp, use the latest version.
           Product: Tomcat 7
           Version: 7.0.54
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
          Assignee: dev@tomcat.apache.org
          Reporter: knst.kolinko@gmail.com

In 8.0.9, 7.0.54: [1]
Reviewing the loop that finds correct web application version by a sessionid.

Looking at [1], there shall be a "break;" after line 921.

This matters in the following rare scenario:
1. There are several versions of the same web application that are deployed in
parallel.
2. The same sessionid is valid both for the latest version and for some older
one.
3. Expected result: map request to the latest version of the webapp.
Actual result: the latest version will be skipped and the request will be
mapped to an older version.


[1]
http://svn.apache.org/viewvc/tomcat/tc8.0.x/tags/TOMCAT_8_0_9/java/org/apache/catalina/connector/CoyoteAdapter.java?view=markup#l916

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56657] Parallel deployment. If sessionid belongs to the latest version of webapp, use the latest version.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56657

--- Comment #2 from Konstantin Kolinko <kn...@gmail.com> ---
Additional minor issue in the same place.

There is no check that on the second mapping loop the "version" was applied to
the same path as on the first loop.

If there is the following configuration:
ROOT#0
ROOT#latest
bar#0
bar#1

Consider that a request for "bar#0" comes in. It performs a remapping loop to
select the "0" version. Consider that bar#0 is paused and third remapping loop
is required.

If both "bar#0" and "bar#1" are undeployed before remapping, the version
variable remains "0", but it is being applied to a different path. So it may
select ROOT#0 instead of expected ROOT#latest.

Given the complexity of configuration to observe this, it is kind of a
theoretical issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56657] Parallel deployment. If sessionid belongs to the latest version of webapp, use the latest version.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56657

--- Comment #3 from Konstantin Kolinko <kn...@gmail.com> ---
(In reply to Konstantin Kolinko from comment #2)

Fixed by r1604661 r1604662 and will be in 7.0.55, 8.0.10 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 56657] Parallel deployment. If sessionid belongs to the latest version of webapp, use the latest version.

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=56657

Konstantin Kolinko <kn...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 OS|                            |All

--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> ---
Fixed by r1604605 r1604607 and will be in 7.0.55, 8.0.10 onwards.

Tomcat 6 is not affected, it does not implement parallel deployment.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org