You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/05/01 17:45:20 UTC
[Impala-ASF-CR] IMPALA-14026: Migrate test files that assert Beeswax dml result.
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22846
Change subject: IMPALA-14026: Migrate test files that assert Beeswax dml result.
......................................................................
IMPALA-14026: Migrate test files that assert Beeswax dml result.
This patch migrate the remaining test file under testdata/ that verify
the beeswax-specific dml result. The RESULTS section is replaced by
RUNTIME_PROFILE section that validates Partition name, NumModifiedRows,
and sum of NumModifiedRows if necessary.
Added HS2_TYPES section where necessary to let tests pass.
Testing:
Pass core tests.
Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
---
M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M testdata/workloads/functional-query/queries/QueryTest/calcite.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/create-table.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-caching.test
M testdata/workloads/functional-query/queries/QueryTest/incompatible_avro_partition.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/insert_null.test
M testdata/workloads/functional-query/queries/QueryTest/insert_overwrite.test
M testdata/workloads/functional-query/queries/QueryTest/insert_part_key.test
M testdata/workloads/functional-query/queries/QueryTest/insert_permutation.test
M testdata/workloads/functional-query/queries/QueryTest/joins.test
M testdata/workloads/functional-query/queries/QueryTest/load.test
M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-regression-exhaustive.test
M testdata/workloads/tpcds-insert/queries/partitioned-insert.test
19 files changed, 1,428 insertions(+), 786 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/22846/1
--
To view, visit http://gerrit.cloudera.org:8080/22846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
Gerrit-Change-Number: 22846
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14026: Migrate test files that assert Beeswax dml result.
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22846 )
Change subject: IMPALA-14026: Migrate test files that assert Beeswax dml result.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
Gerrit-Change-Number: 22846
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 May 2025 18:02:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14026: Migrate test files that assert Beeswax dml result.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22846 )
Change subject: IMPALA-14026: Migrate test files that assert Beeswax dml result.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19087/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
Gerrit-Change-Number: 22846
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 May 2025 18:12:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14026: Migrate test files that assert Beeswax dml result.
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22846 )
Change subject: IMPALA-14026: Migrate test files that assert Beeswax dml result.
......................................................................
IMPALA-14026: Migrate test files that assert Beeswax dml result.
This patch migrate the remaining test file under testdata/ that verify
the beeswax-specific dml result. The RESULTS section is replaced by
RUNTIME_PROFILE section that validates Partition name, NumModifiedRows,
and sum of NumModifiedRows if necessary.
Added HS2_TYPES section where necessary to let tests pass.
Testing:
Pass core tests.
Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
Reviewed-on: http://gerrit.cloudera.org:8080/22846
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M testdata/workloads/functional-query/queries/DataErrorsTest/orc-type-checks.test
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M testdata/workloads/functional-query/queries/QueryTest/calcite.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test
M testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test
M testdata/workloads/functional-query/queries/QueryTest/create-table.test
M testdata/workloads/functional-query/queries/QueryTest/hdfs-caching.test
M testdata/workloads/functional-query/queries/QueryTest/incompatible_avro_partition.test
M testdata/workloads/functional-query/queries/QueryTest/insert.test
M testdata/workloads/functional-query/queries/QueryTest/insert_null.test
M testdata/workloads/functional-query/queries/QueryTest/insert_overwrite.test
M testdata/workloads/functional-query/queries/QueryTest/insert_part_key.test
M testdata/workloads/functional-query/queries/QueryTest/insert_permutation.test
M testdata/workloads/functional-query/queries/QueryTest/joins.test
M testdata/workloads/functional-query/queries/QueryTest/load.test
M testdata/workloads/functional-query/queries/QueryTest/partition-col-types.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-regression-exhaustive.test
M testdata/workloads/tpcds-insert/queries/partitioned-insert.test
19 files changed, 1,428 insertions(+), 786 deletions(-)
Approvals:
Michael Smith: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
Gerrit-Change-Number: 22846
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14026: Migrate test files that assert Beeswax dml result.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22846 )
Change subject: IMPALA-14026: Migrate test files that assert Beeswax dml result.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
Gerrit-Change-Number: 22846
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 May 2025 11:52:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14026: Migrate test files that assert Beeswax dml result.
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22846 )
Change subject: IMPALA-14026: Migrate test files that assert Beeswax dml result.
......................................................................
Patch Set 1: Code-Review+2
This makes sense to me
--
To view, visit http://gerrit.cloudera.org:8080/22846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
Gerrit-Change-Number: 22846
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 May 2025 19:41:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14026: Migrate test files that assert Beeswax dml result.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22846 )
Change subject: IMPALA-14026: Migrate test files that assert Beeswax dml result.
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11830/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
Gerrit-Change-Number: 22846
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 May 2025 05:26:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14026: Migrate test files that assert Beeswax dml result.
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22846 )
Change subject: IMPALA-14026: Migrate test files that assert Beeswax dml result.
......................................................................
Patch Set 2:
Thanks everyone for your review!
--
To view, visit http://gerrit.cloudera.org:8080/22846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36efbe66b654a5af6c44710e55d0b755280ad3be
Gerrit-Change-Number: 22846
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 May 2025 20:04:21 +0000
Gerrit-HasComments: No