You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/07 11:37:21 UTC
[GitHub] [airflow] DImho opened a new pull request #19452: Moved hive macros to the providers package
DImho opened a new pull request #19452:
URL: https://github.com/apache/airflow/pull/19452
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes #19445
This PR contains the following changes:
* A new package `airflow.providers.apache.hive.macros` has been created (cd896e3a20e37f2ca0fca97b84540c7c575e0108)
* The hive macro module previously residing under `airflow.macros.hive` has been moved to `airflow.providers.apache.hive.macros.hive`
* Affected import statments have been modified (2f6d68258fed59c3bc5514f538ee276db987ebcd)
The `airflow.macros` package still remains since there are macros residing in `__init__.py` unrelated to hive.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19452: Moved hive macros to the providers package
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19452:
URL: https://github.com/apache/airflow/pull/19452#issuecomment-962594659
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #19452: Moved hive macros to the providers package
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #19452:
URL: https://github.com/apache/airflow/pull/19452#discussion_r744245495
##########
File path: airflow/macros/__init__.py
##########
@@ -22,7 +22,7 @@
import dateutil # noqa
-from airflow.macros import hive # noqa
+from airflow.providers.apache.hive.macros import hive # noqa
Review comment:
We should not import modules from the airflow.providers package in the top-level code as this creates hard dependencies. Now everyone must have Apache Hive provider installed to use the `airflow.macros` module.
We should extend [airflow.providers_manager](https://github.com/apache/airflow/blob/main/airflow/providers_manager.py) with macro support. It should look similar to support macros in plugin_manager.
https://github.com/apache/airflow/blob/3a7e687a369986a35c83ab374ed0e9dc040ecdae/airflow/plugins_manager.py#L428-L458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mrveera commented on a change in pull request #19452: Moved hive macros to the providers package
Posted by GitBox <gi...@apache.org>.
mrveera commented on a change in pull request #19452:
URL: https://github.com/apache/airflow/pull/19452#discussion_r745289374
##########
File path: tests/macros/test_hive.py
##########
@@ -19,7 +19,7 @@
import unittest
from datetime import datetime
-from airflow.macros import hive
+from airflow.providers.apache.hive.macros import hive
Review comment:
Tests also should co-locate with other tests of this provider not under and macros package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] veera-rapido commented on a change in pull request #19452: Moved hive macros to the providers package
Posted by GitBox <gi...@apache.org>.
veera-rapido commented on a change in pull request #19452:
URL: https://github.com/apache/airflow/pull/19452#discussion_r745289230
##########
File path: tests/macros/test_hive.py
##########
@@ -19,7 +19,7 @@
import unittest
from datetime import datetime
-from airflow.macros import hive
+from airflow.providers.apache.hive.macros import hive
Review comment:
Tests also should co-locate with other tests of this provider not under and macros package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #19452: Moved hive macros to the providers package
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #19452:
URL: https://github.com/apache/airflow/pull/19452#discussion_r744245495
##########
File path: airflow/macros/__init__.py
##########
@@ -22,7 +22,7 @@
import dateutil # noqa
-from airflow.macros import hive # noqa
+from airflow.providers.apache.hive.macros import hive # noqa
Review comment:
We should not import modules from the airflow.providers package in the top-level code as this creates hard dependencies. Now everyone must have Apache Hive provider installed to use the `airflow.macros` module.
We should extend [airflow.providers_manager](https://github.com/apache/airflow/blob/main/airflow/providers_manager.py) with macro support. It should look similar to support macros in plugin_manager.
https://github.com/apache/airflow/blob/main/airflow/plugins_manager.py#L428-L458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #19452: Moved hive macros to the providers package
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #19452:
URL: https://github.com/apache/airflow/pull/19452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19452: Moved hive macros to the providers package
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19452:
URL: https://github.com/apache/airflow/pull/19452#issuecomment-1000949527
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org